[GitHub] [lucene] jainankitk edited a comment on pull request #711: LUCENE-10428: Avoid infinite loop under error conditions.

[GitBox <gi...@apache.org>]

jainankitk edited a comment on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1057396494


   > This gave me the idea that we can use negative values for a test at least. I PRed [jpountz#2](https://github.com/jpountz/lucene/pull/2) into your branch: it reproduces this issue with negative scores, and can now validate the new expectation of an `IllegalStateException` being thrown.
   
   Thats great! and much better than parameterizing for testing `IllegalStateException`. I have reviewed and approved the changes for [jpountz#2](https://github.com/jpountz/lucene/pull/2)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org