[GitHub] [incubator-pegasus] acelyc111 commented on pull request #1290: refactor(idl): unify the *.thrift files used by cpp and java-client

[GitBox <gi...@apache.org>]

acelyc111 commented on PR #1290:
URL: https://github.com/apache/incubator-pegasus/pull/1290#issuecomment-1351833508

   > I think we'd beter bump the major version to include this break changes?
   > 
   > And do we have a compatibilty guide about what things can be broken while upgrading?
   > 
   > And it is a bit strange that, why java client and cpp client can use different thrift defination while they connect to the same server?
   
   1. That would be better, but I'm afraid there may be some more compatiblity changes in the future, the major version will inscrease too frequently then.
   2. We will point that out obviously in the release note, as how we do before.
   3. No matter what the name of the struct or field is, they are compatiable. When decode a request message from client on server, it depends on what the rpc code is, then use the related struct to decode it. For the fields, only the numberic tags are used, no matter what the names are.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org