You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by John Sirois <js...@apache.org> on 2016/03/28 00:36:55 UTC
Review Request 45366: Eliminate I* isSet methods for collection
fields.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45366/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Bugs: AURORA-1650
https://issues.apache.org/jira/browse/AURORA-1650
Repository: aurora
Description
-------
These methods always returned `true`, which was misleading. Eliminate
these query methods and force users to consult the collection for
emptiness to make intentions more clear.
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java | 3 +--
src/main/java/org/apache/aurora/scheduler/http/Mname.java | 4 +---
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java | 4 +---
src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java | 2 +-
src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java | 1 -
src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py | 2 +-
6 files changed, 5 insertions(+), 11 deletions(-)
Diffs
-----
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java b3b8ccf868c2a2f18f720a837e90d763072dd3eb
src/main/java/org/apache/aurora/scheduler/http/Mname.java 807a1989473f1a933790e5837d804941419007a3
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 20cbd419dcb988f2c7ba72c8acbe6fee90d02248
src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 4b0ef81e5dd2723291a9810980246c6c3e7924f5
src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 69010985aa066ebb6686f256a734d77e008ccd1a
src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py e9e9368328992cb8cc26eb22d86aa244d5fa9250
Diff: https://reviews.apache.org/r/45366/diff/
Testing
-------
Locally green:
```
./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
Thanks,
John Sirois
Re: Review Request 45366: Eliminate I* isSet methods for collection
fields.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45366/#review125590
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On March 27, 2016, 3:39 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45366/
> -----------------------------------------------------------
>
> (Updated March 27, 2016, 3:39 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1650
> https://issues.apache.org/jira/browse/AURORA-1650
>
>
> Repository: aurora
>
>
> Description
> -------
>
> These methods always returned `true`, which was misleading. Eliminate
> these query methods and force users to consult the collection for
> emptiness to make intentions more clear.
>
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java | 3 +--
> src/main/java/org/apache/aurora/scheduler/http/Mname.java | 4 +---
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java | 4 +---
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java | 2 +-
> src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java | 1 -
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py | 2 +-
> 6 files changed, 5 insertions(+), 11 deletions(-)
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java b3b8ccf868c2a2f18f720a837e90d763072dd3eb
> src/main/java/org/apache/aurora/scheduler/http/Mname.java 807a1989473f1a933790e5837d804941419007a3
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 20cbd419dcb988f2c7ba72c8acbe6fee90d02248
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 4b0ef81e5dd2723291a9810980246c6c3e7924f5
> src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 69010985aa066ebb6686f256a734d77e008ccd1a
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py e9e9368328992cb8cc26eb22d86aa244d5fa9250
>
> Diff: https://reviews.apache.org/r/45366/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 45366: Eliminate I* isSet methods for collection
fields.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45366/#review125582
-----------------------------------------------------------
Master (b352e8b) is red with this patch.
./build-support/jenkins/build.sh
[1m self._clock.tick(0.5 + epsilon)[0m
[1m self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m self._clock.assert_waiting(hct.threaded_health_checker, amount=1) # interval_secs[0m
[1m assert hct._total_latency == 0.5[0m
[1m assert hct.metrics.sample()['total_latency_secs'] == 0.5[0m
[1m assert hct.metrics.sample()['checks'] == 1[0m
[1m [0m
[1m # tick again[0m
[1m self._clock.tick(1.0 + epsilon)[0m
[1m self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m self._clock.tick(0.5 + epsilon)[0m
[1m self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m self._clock.assert_waiting(hct.threaded_health_checker, amount=1) # interval_secs[0m
[1m> assert hct._total_latency == 1.0[0m
[1m[31mE AssertionError: assert 1.001 == 1.0[0m
[1m[31mE + where 1.001 = <apache.aurora.executor.common.health_checker.HealthChecker object at 0x7f40aed369d0>._total_latency[0m
src/test/python/apache/aurora/executor/common/test_health_checker.py:184: AssertionError
-------------- Captured stderr call --------------
[<twitter.common.testing.clock.ThreadedClock object at 0x7f40aed36e10>] Time now: 0.0
[<twitter.common.testing.clock.ThreadedClock object at 0x7f40aed36e10>] Time now: 0.0
[<twitter.common.testing.clock.ThreadedClock object at 0x7f40aed36e10>] Time now: 1.0
[<twitter.common.testing.clock.ThreadedClock object at 0x7f40aed36e10>] Time now: 1.001
[<twitter.common.testing.clock.ThreadedClock object at 0x7f40aed36e10>] Time now: 1.001
[<twitter.common.testing.clock.ThreadedClock object at 0x7f40aed36e10>] Time now: 1.501
[<twitter.common.testing.clock.ThreadedClock object at 0x7f40aed36e10>] Time now: 1.502
[<twitter.common.testing.clock.ThreadedClock object at 0x7f40aed36e10>] Time now: 1.502
[<twitter.common.testing.clock.ThreadedClock object at 0x7f40aed36e10>] Time now: 2.502
[<twitter.common.testing.clock.ThreadedClock object at 0x7f40aed36e10>] Time now: 2.503
[<twitter.common.testing.clock.ThreadedClock object at 0x7f40aed36e10>] Time now: 2.503
[<twitter.common.testing.clock.ThreadedClock object at 0x7f40aed36e10>] Time now: 3.003
[<twitter.common.testing.clock.ThreadedClock object at 0x7f40aed36e10>] Time now: 3.004
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 1 failed, 663 passed, 5 skipped, 1 warnings in 291.87 seconds [0m
FAILURE
23:37:28 06:38 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 27, 2016, 10:39 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45366/
> -----------------------------------------------------------
>
> (Updated March 27, 2016, 10:39 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1650
> https://issues.apache.org/jira/browse/AURORA-1650
>
>
> Repository: aurora
>
>
> Description
> -------
>
> These methods always returned `true`, which was misleading. Eliminate
> these query methods and force users to consult the collection for
> emptiness to make intentions more clear.
>
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java | 3 +--
> src/main/java/org/apache/aurora/scheduler/http/Mname.java | 4 +---
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java | 4 +---
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java | 2 +-
> src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java | 1 -
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py | 2 +-
> 6 files changed, 5 insertions(+), 11 deletions(-)
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java b3b8ccf868c2a2f18f720a837e90d763072dd3eb
> src/main/java/org/apache/aurora/scheduler/http/Mname.java 807a1989473f1a933790e5837d804941419007a3
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 20cbd419dcb988f2c7ba72c8acbe6fee90d02248
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 4b0ef81e5dd2723291a9810980246c6c3e7924f5
> src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 69010985aa066ebb6686f256a734d77e008ccd1a
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py e9e9368328992cb8cc26eb22d86aa244d5fa9250
>
> Diff: https://reviews.apache.org/r/45366/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 45366: Eliminate I* isSet methods for collection
fields.
Posted by John Sirois <js...@apache.org>.
> On March 27, 2016, 4:59 p.m., Aurora ReviewBot wrote:
> > Master (b352e8b) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > :processTestResources
> > :testClasses
> > :checkstyleTest
> > :findbugsJmh
> > :findbugsMain
> > :findbugsTest
> > :licenseJmh UP-TO-DATE
> > :licenseMain UP-TO-DATE
> > :licenseTest UP-TO-DATE
> > :license UP-TO-DATE
> > :pmdJmh
> > :pmdMain
> > :pmdTest
> > :test
> >
> > org.apache.aurora.scheduler.http.api.security.HttpSecurityIT > testH2ConsoleUser FAILED
> > java.lang.RuntimeException
> > I0327 22:58:35.386 [ShutdownHook, SchedulerMain:99] Stopping scheduler services.
> > I0327 22:58:35.466 [RedirectMonitor STARTING-SendThread(localhost:39726), ClientCnxn$SendThread:1032] Opening socket connection to server localhost/0:0:0:0:0:0:0:1:39726. Will not attempt to authenticate using SASL (unknown error)
> >
> > 945 tests completed, 1 failed, 2 skipped
> > :test FAILED
> > :jacocoTestReport
> > Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
> > :analyzeReport
> > Instruction coverage is 0.8850341435461535, but must be greater than 0.89
> > Branch coverage is 0.8062213156552779, but must be greater than 0.835
> >
> > FAILURE: Build failed with an exception.
> >
> > * What went wrong:
> > Execution failed for task ':test'.
> > > There were failing tests. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/tests/index.html
> >
> > * Try:
> > Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
> >
> > BUILD FAILED
> >
> > Total time: 17 mins 24.122 secs
> >
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
This was in `org.apache.aurora.scheduler.http.api.security.HttpSecurityIT#testH2ConsoleUser`:
```
java.lang.RuntimeException: Tear down did not complete cleanly: [java.util.concurrent.TimeoutException: Timeout waiting for the services to stop. The following services have not stopped: {STOPPING=[RegisterGauges [TERMINATED], HttpServerLauncher [STOPPING], RedirectMonitor [TERMINATED]]}]
at org.apache.aurora.common.testing.TearDownTestCase.tearDown(TearDownTestCase.java:44)
...
```
I'll give it a retry.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45366/#review125576
-----------------------------------------------------------
On March 27, 2016, 4:39 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45366/
> -----------------------------------------------------------
>
> (Updated March 27, 2016, 4:39 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1650
> https://issues.apache.org/jira/browse/AURORA-1650
>
>
> Repository: aurora
>
>
> Description
> -------
>
> These methods always returned `true`, which was misleading. Eliminate
> these query methods and force users to consult the collection for
> emptiness to make intentions more clear.
>
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java | 3 +--
> src/main/java/org/apache/aurora/scheduler/http/Mname.java | 4 +---
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java | 4 +---
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java | 2 +-
> src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java | 1 -
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py | 2 +-
> 6 files changed, 5 insertions(+), 11 deletions(-)
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java b3b8ccf868c2a2f18f720a837e90d763072dd3eb
> src/main/java/org/apache/aurora/scheduler/http/Mname.java 807a1989473f1a933790e5837d804941419007a3
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 20cbd419dcb988f2c7ba72c8acbe6fee90d02248
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 4b0ef81e5dd2723291a9810980246c6c3e7924f5
> src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 69010985aa066ebb6686f256a734d77e008ccd1a
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py e9e9368328992cb8cc26eb22d86aa244d5fa9250
>
> Diff: https://reviews.apache.org/r/45366/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 45366: Eliminate I* isSet methods for collection
fields.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45366/#review125576
-----------------------------------------------------------
Master (b352e8b) is red with this patch.
./build-support/jenkins/build.sh
:processTestResources
:testClasses
:checkstyleTest
:findbugsJmh
:findbugsMain
:findbugsTest
:licenseJmh UP-TO-DATE
:licenseMain UP-TO-DATE
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdJmh
:pmdMain
:pmdTest
:test
org.apache.aurora.scheduler.http.api.security.HttpSecurityIT > testH2ConsoleUser FAILED
java.lang.RuntimeException
I0327 22:58:35.386 [ShutdownHook, SchedulerMain:99] Stopping scheduler services.
I0327 22:58:35.466 [RedirectMonitor STARTING-SendThread(localhost:39726), ClientCnxn$SendThread:1032] Opening socket connection to server localhost/0:0:0:0:0:0:0:1:39726. Will not attempt to authenticate using SASL (unknown error)
945 tests completed, 1 failed, 2 skipped
:test FAILED
:jacocoTestReport
Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:analyzeReport
Instruction coverage is 0.8850341435461535, but must be greater than 0.89
Branch coverage is 0.8062213156552779, but must be greater than 0.835
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/tests/index.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 17 mins 24.122 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 27, 2016, 10:39 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45366/
> -----------------------------------------------------------
>
> (Updated March 27, 2016, 10:39 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1650
> https://issues.apache.org/jira/browse/AURORA-1650
>
>
> Repository: aurora
>
>
> Description
> -------
>
> These methods always returned `true`, which was misleading. Eliminate
> these query methods and force users to consult the collection for
> emptiness to make intentions more clear.
>
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java | 3 +--
> src/main/java/org/apache/aurora/scheduler/http/Mname.java | 4 +---
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java | 4 +---
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java | 2 +-
> src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java | 1 -
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py | 2 +-
> 6 files changed, 5 insertions(+), 11 deletions(-)
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java b3b8ccf868c2a2f18f720a837e90d763072dd3eb
> src/main/java/org/apache/aurora/scheduler/http/Mname.java 807a1989473f1a933790e5837d804941419007a3
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 20cbd419dcb988f2c7ba72c8acbe6fee90d02248
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 4b0ef81e5dd2723291a9810980246c6c3e7924f5
> src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 69010985aa066ebb6686f256a734d77e008ccd1a
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py e9e9368328992cb8cc26eb22d86aa244d5fa9250
>
> Diff: https://reviews.apache.org/r/45366/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 45366: Eliminate I* isSet methods for collection
fields.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45366/#review125578
-----------------------------------------------------------
@ReviewBot retry
- John Sirois
On March 27, 2016, 4:39 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45366/
> -----------------------------------------------------------
>
> (Updated March 27, 2016, 4:39 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1650
> https://issues.apache.org/jira/browse/AURORA-1650
>
>
> Repository: aurora
>
>
> Description
> -------
>
> These methods always returned `true`, which was misleading. Eliminate
> these query methods and force users to consult the collection for
> emptiness to make intentions more clear.
>
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java | 3 +--
> src/main/java/org/apache/aurora/scheduler/http/Mname.java | 4 +---
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java | 4 +---
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java | 2 +-
> src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java | 1 -
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py | 2 +-
> 6 files changed, 5 insertions(+), 11 deletions(-)
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java b3b8ccf868c2a2f18f720a837e90d763072dd3eb
> src/main/java/org/apache/aurora/scheduler/http/Mname.java 807a1989473f1a933790e5837d804941419007a3
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 20cbd419dcb988f2c7ba72c8acbe6fee90d02248
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 4b0ef81e5dd2723291a9810980246c6c3e7924f5
> src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 69010985aa066ebb6686f256a734d77e008ccd1a
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py e9e9368328992cb8cc26eb22d86aa244d5fa9250
>
> Diff: https://reviews.apache.org/r/45366/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 45366: Eliminate I* isSet methods for collection
fields.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45366/#review125586
-----------------------------------------------------------
Master (b352e8b) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 27, 2016, 10:39 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45366/
> -----------------------------------------------------------
>
> (Updated March 27, 2016, 10:39 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1650
> https://issues.apache.org/jira/browse/AURORA-1650
>
>
> Repository: aurora
>
>
> Description
> -------
>
> These methods always returned `true`, which was misleading. Eliminate
> these query methods and force users to consult the collection for
> emptiness to make intentions more clear.
>
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java | 3 +--
> src/main/java/org/apache/aurora/scheduler/http/Mname.java | 4 +---
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java | 4 +---
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java | 2 +-
> src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java | 1 -
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py | 2 +-
> 6 files changed, 5 insertions(+), 11 deletions(-)
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java b3b8ccf868c2a2f18f720a837e90d763072dd3eb
> src/main/java/org/apache/aurora/scheduler/http/Mname.java 807a1989473f1a933790e5837d804941419007a3
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 20cbd419dcb988f2c7ba72c8acbe6fee90d02248
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 4b0ef81e5dd2723291a9810980246c6c3e7924f5
> src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 69010985aa066ebb6686f256a734d77e008ccd1a
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py e9e9368328992cb8cc26eb22d86aa244d5fa9250
>
> Diff: https://reviews.apache.org/r/45366/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 45366: Eliminate I* isSet methods for collection
fields.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45366/#review125583
-----------------------------------------------------------
@ReviewBot retry
- John Sirois
On March 27, 2016, 4:39 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45366/
> -----------------------------------------------------------
>
> (Updated March 27, 2016, 4:39 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1650
> https://issues.apache.org/jira/browse/AURORA-1650
>
>
> Repository: aurora
>
>
> Description
> -------
>
> These methods always returned `true`, which was misleading. Eliminate
> these query methods and force users to consult the collection for
> emptiness to make intentions more clear.
>
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java | 3 +--
> src/main/java/org/apache/aurora/scheduler/http/Mname.java | 4 +---
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java | 4 +---
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java | 2 +-
> src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java | 1 -
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py | 2 +-
> 6 files changed, 5 insertions(+), 11 deletions(-)
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java b3b8ccf868c2a2f18f720a837e90d763072dd3eb
> src/main/java/org/apache/aurora/scheduler/http/Mname.java 807a1989473f1a933790e5837d804941419007a3
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 20cbd419dcb988f2c7ba72c8acbe6fee90d02248
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 4b0ef81e5dd2723291a9810980246c6c3e7924f5
> src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 69010985aa066ebb6686f256a734d77e008ccd1a
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py e9e9368328992cb8cc26eb22d86aa244d5fa9250
>
> Diff: https://reviews.apache.org/r/45366/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 45366: Eliminate I* isSet methods for collection
fields.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45366/#review125585
-----------------------------------------------------------
@ReviewBot retry
- John Sirois
On March 27, 2016, 4:39 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45366/
> -----------------------------------------------------------
>
> (Updated March 27, 2016, 4:39 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1650
> https://issues.apache.org/jira/browse/AURORA-1650
>
>
> Repository: aurora
>
>
> Description
> -------
>
> These methods always returned `true`, which was misleading. Eliminate
> these query methods and force users to consult the collection for
> emptiness to make intentions more clear.
>
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java | 3 +--
> src/main/java/org/apache/aurora/scheduler/http/Mname.java | 4 +---
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java | 4 +---
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java | 2 +-
> src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java | 1 -
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py | 2 +-
> 6 files changed, 5 insertions(+), 11 deletions(-)
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java b3b8ccf868c2a2f18f720a837e90d763072dd3eb
> src/main/java/org/apache/aurora/scheduler/http/Mname.java 807a1989473f1a933790e5837d804941419007a3
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 20cbd419dcb988f2c7ba72c8acbe6fee90d02248
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 4b0ef81e5dd2723291a9810980246c6c3e7924f5
> src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 69010985aa066ebb6686f256a734d77e008ccd1a
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py e9e9368328992cb8cc26eb22d86aa244d5fa9250
>
> Diff: https://reviews.apache.org/r/45366/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 45366: Eliminate I* isSet methods for collection
fields.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45366/#review125584
-----------------------------------------------------------
Master (b352e8b) is red with this patch.
./build-support/jenkins/build.sh
[1m self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m self._clock.assert_waiting(hct.threaded_health_checker, amount=1)[0m
[1m [0m
[1m assert hct._total_latency == 0[0m
[1m assert hct.metrics.sample()['total_latency_secs'] == 0[0m
[1m [0m
[1m # start the health check (during health check it is still 0)[0m
[1m epsilon = 0.001[0m
[1m self._clock.tick(1.0 + epsilon)[0m
[1m self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m self._clock.assert_waiting(hct.threaded_health_checker, amount=0.5)[0m
[1m assert hct._total_latency == 0[0m
[1m assert hct.metrics.sample()['total_latency_secs'] == 0[0m
[1m assert hct.metrics.sample()['checks'] == 0[0m
[1m [0m
[1m # finish the health check[0m
[1m self._clock.tick(0.5 + epsilon)[0m
[1m self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m self._clock.assert_waiting(hct.threaded_health_checker, amount=1) # interval_secs[0m
[1m> assert hct._total_latency == 0.5[0m
[1m[31mE AssertionError: assert 0.5009999999999999 == 0.5[0m
[1m[31mE + where 0.5009999999999999 = <apache.aurora.executor.common.health_checker.HealthChecker object at 0x7f656b43e790>._total_latency[0m
src/test/python/apache/aurora/executor/common/test_health_checker.py:174: AssertionError
-------------- Captured stderr call --------------
[<twitter.common.testing.clock.ThreadedClock object at 0x7f656b43e8d0>] Time now: 0.0
[<twitter.common.testing.clock.ThreadedClock object at 0x7f656b43e8d0>] Time now: 0.0
[<twitter.common.testing.clock.ThreadedClock object at 0x7f656b43e8d0>] Time now: 1.0
[<twitter.common.testing.clock.ThreadedClock object at 0x7f656b43e8d0>] Time now: 1.001
[<twitter.common.testing.clock.ThreadedClock object at 0x7f656b43e8d0>] Time now: 1.001
[<twitter.common.testing.clock.ThreadedClock object at 0x7f656b43e8d0>] Time now: 1.501
[<twitter.common.testing.clock.ThreadedClock object at 0x7f656b43e8d0>] Time now: 1.502
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 1 failed, 663 passed, 5 skipped, 1 warnings in 305.19 seconds [0m
FAILURE
00:17:10 06:52 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 27, 2016, 10:39 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45366/
> -----------------------------------------------------------
>
> (Updated March 27, 2016, 10:39 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1650
> https://issues.apache.org/jira/browse/AURORA-1650
>
>
> Repository: aurora
>
>
> Description
> -------
>
> These methods always returned `true`, which was misleading. Eliminate
> these query methods and force users to consult the collection for
> emptiness to make intentions more clear.
>
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java | 3 +--
> src/main/java/org/apache/aurora/scheduler/http/Mname.java | 4 +---
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java | 4 +---
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java | 2 +-
> src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java | 1 -
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py | 2 +-
> 6 files changed, 5 insertions(+), 11 deletions(-)
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java b3b8ccf868c2a2f18f720a837e90d763072dd3eb
> src/main/java/org/apache/aurora/scheduler/http/Mname.java 807a1989473f1a933790e5837d804941419007a3
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 20cbd419dcb988f2c7ba72c8acbe6fee90d02248
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 4b0ef81e5dd2723291a9810980246c6c3e7924f5
> src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 69010985aa066ebb6686f256a734d77e008ccd1a
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py e9e9368328992cb8cc26eb22d86aa244d5fa9250
>
> Diff: https://reviews.apache.org/r/45366/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 45366: Eliminate I* isSet methods for collection
fields.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45366/
-----------------------------------------------------------
(Updated March 27, 2016, 4:39 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Kill mistakenly introduced extra parens.
src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Bugs: AURORA-1650
https://issues.apache.org/jira/browse/AURORA-1650
Repository: aurora
Description
-------
These methods always returned `true`, which was misleading. Eliminate
these query methods and force users to consult the collection for
emptiness to make intentions more clear.
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java | 3 +--
src/main/java/org/apache/aurora/scheduler/http/Mname.java | 4 +---
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java | 4 +---
src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java | 2 +-
src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java | 1 -
src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py | 2 +-
6 files changed, 5 insertions(+), 11 deletions(-)
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java b3b8ccf868c2a2f18f720a837e90d763072dd3eb
src/main/java/org/apache/aurora/scheduler/http/Mname.java 807a1989473f1a933790e5837d804941419007a3
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 20cbd419dcb988f2c7ba72c8acbe6fee90d02248
src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 4b0ef81e5dd2723291a9810980246c6c3e7924f5
src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 69010985aa066ebb6686f256a734d77e008ccd1a
src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py e9e9368328992cb8cc26eb22d86aa244d5fa9250
Diff: https://reviews.apache.org/r/45366/diff/
Testing
-------
Locally green:
```
./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
Thanks,
John Sirois