You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Michael Osipov (Jira)" <ji...@apache.org> on 2022/07/24 16:52:00 UTC

[jira] [Closed] (SCM-925) Implement RemoveCommand in maven-scm-provider-jgit with TCK test for all providers

     [ https://issues.apache.org/jira/browse/SCM-925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Osipov closed SCM-925.
------------------------------
    Resolution: Fixed

Fixed with [2a70033c4bcb5bdf28892292a6f8566c56abd7d2|https://gitbox.apache.org/repos/asf?p=maven-scm.git;a=commit;h=2a70033c4bcb5bdf28892292a6f8566c56abd7d2].

Many thanks to [~kwin] for helping out!

> Implement RemoveCommand in maven-scm-provider-jgit with TCK test for all providers
> ----------------------------------------------------------------------------------
>
>                 Key: SCM-925
>                 URL: https://issues.apache.org/jira/browse/SCM-925
>             Project: Maven SCM
>          Issue Type: Improvement
>          Components: maven-scm-provider-jgit
>    Affects Versions: 1.11.2
>            Reporter: Georg Tsakumagos
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 2.0.0-M2
>
>         Attachments: maven-scm-provider-jgit.log
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The git scm plugins differs in support for the scm command _remove_. This breaks the goal _prepare-with-pom_ of the _maven-release-plugin_ using the _maven-scm-provider-jgit_. The method is not fully implemented and throws an UnsupportedOperationException. 
> Referring to the ["Maven SCM Providers Matrix"|https://maven.apache.org/scm/matrix.html] this feature is documented as supported and should be implemented in the _jgit_ provider like in maven-scm-provider-gitexe.
>  
> ||Variant||remove supported||Source||
> |maven-scm-provider-gitexe|(/)|[Github - GitExeScmProvider.java - getRemoveCommand()|https://github.com/apache/maven-scm/blob/a1f7e9857076940c878a370ff599b394df768d33/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/GitExeScmProvider.java#L97]|
> |maven-scm-provider-jgit|(x)|[Github - JGitScmProvider.java - getRemoveCommand()|https://github.com/apache/maven-scm/blob/a1f7e9857076940c878a370ff599b394df768d33/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/JGitScmProvider.java#L113]|
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)