[GitHub] [incubator-druid] himanshug commented on a change in pull request #8088: Add intermediary data server for shuffle

[GitBox <gi...@apache.org>]

himanshug commented on a change in pull request #8088: Add intermediary data server for shuffle
URL: https://github.com/apache/incubator-druid/pull/8088#discussion_r304063075
 
 

 ##########
 File path: indexing-service/src/main/java/org/apache/druid/indexing/common/config/TaskConfig.java
 ##########
 @@ -89,6 +94,13 @@ public TaskConfig(
     this.directoryLockTimeout = directoryLockTimeout == null
                                 ? DEFAULT_DIRECTORY_LOCK_TIMEOUT
                                 : directoryLockTimeout;
+    if (intermediarySegmentsLocations == null) {
+      this.intermediarySegmentsLocations = Collections.singletonList(
+          new StorageLocationConfig(new File(System.getProperty("java.io.tmpdir"), "intermediary-segments"), null, null)
 
 Review comment:
   ```suggestion
             new StorageLocationConfig(new File(defaultDir(null, "intermediary-segments")), null, null)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org