[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5561: Validation for timeColumnName (#5558)

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #5561:
URL: https://github.com/apache/incubator-pinot/pull/5561#discussion_r440542801



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java
##########
@@ -445,6 +445,9 @@ private void verifyTableConfigs(TableConfig newTableConfig) {
     SegmentsValidationAndRetentionConfig SegmentConfigToCompare = tableConfigToCompare.getValidationConfig();
 
     String newTimeColumnName = newSegmentConfig.getTimeColumnName();
+    if(newTimeColumnName == null) {

Review comment:
       This can only catch the issue for hybrid table, but not realtime-only table. I would suggest adding the check into `TableConfigUtils.validate()`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org