You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/09 19:09:10 UTC

[GitHub] [airflow] itroulli commented on a change in pull request #15194: Adds description field in variable (#12413)

itroulli commented on a change in pull request #15194:
URL: https://github.com/apache/airflow/pull/15194#discussion_r610850423



##########
File path: airflow/www/views.py
##########
@@ -3145,9 +3145,9 @@ class VariableModelView(AirflowModelView):
         permissions.ACTION_CAN_ACCESS_MENU,
     ]
 
-    list_columns = ['key', 'val', 'is_encrypted']
-    add_columns = ['key', 'val']
-    edit_columns = ['key', 'val']
+    list_columns = ['key', 'val', 'description', 'is_encrypted']
+    add_columns = ['key', 'val', 'description']
+    edit_columns = ['key', 'val', 'description']

Review comment:
       My thought was that since the description field is option it is better to be after the required ones. I can change it though, if you prefer it to be second.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org