You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/03 03:48:37 UTC

[GitHub] [pulsar] lhotari edited a comment on issue #9432: Flaky-test: NPE in CompactionTest.cleanup

lhotari edited a comment on issue #9432:
URL: https://github.com/apache/pulsar/issues/9432#issuecomment-772201081


   @Wzhipeng Good. btw. I noticed that a similar problem occurs in quite a few test cleanup methods. It must have been a case where the setup method fails before `compactionScheduler` has been created.
   
   Would you mind fixing the NPEs in cleanup methods of these tests in addition to CompactionTest.cleanup? 
   I believe this could be done in the same PR since it's about a similar issue.
   ```
   org.apache.pulsar.compaction.CompactorTest.cleanup
   org.apache.pulsar.websocket.proxy.ProxyAuthenticationTest.cleanup
   org.apache.pulsar.websocket.proxy.ProxyAuthorizationTest.cleanup
   org.apache.pulsar.websocket.proxy.ProxyPublishConsumeTest.cleanup
   org.apache.pulsar.websocket.proxy.ProxyPublishConsumeTlsTest.cleanup
   org.apache.pulsar.websocket.proxy.ProxyPublishConsumeWithoutZKTest.cleanup
   org.apache.pulsar.websocket.proxy.v1.V1_ProxyAuthenticationTest.cleanup
   ```
   The issue might be broader, but there are NPE failures at least in these methods in the last 14 days.
   
   The issue could be renames as "Fix NPEs in test cleanup methods", if this is fine for you.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org