You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/04/21 23:29:56 UTC
[kudu-CR] [client] add -Werror flag for checking client C++ API
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19784
Change subject: [client] add -Werror flag for checking client C++ API
......................................................................
[client] add -Werror flag for checking client C++ API
I noticed that many contemporary C++ compilers didn't error out but
issued a warning instead when compiling a code with C++11 features,
even if running with -std=c++98 flag.
To make the API compatibility check more robust, this patch adds -Werror
flag to make sure the client_examples-test.sh fails if incompatibility
is introduced into corresponding header files.
This is a follow-up to 10b1c30441dd48bebf692db8a41464cf08319908.
Change-Id: Iae550774bd0aaf0b7bb8df7e64ee5b8b0fc22ac3
---
M src/kudu/client/client_examples-test.sh
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/19784/1
--
To view, visit http://gerrit.cloudera.org:8080/19784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae550774bd0aaf0b7bb8df7e64ee5b8b0fc22ac3
Gerrit-Change-Number: 19784
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [client] add -Werror flag for checking client C++ API
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [client] add -Werror flag for checking client C++ API
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Iae550774bd0aaf0b7bb8df7e64ee5b8b0fc22ac3
Gerrit-Change-Number: 19784
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] [client] add -Werror flag for checking client C++ API
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19784 )
Change subject: [client] add -Werror flag for checking client C++ API
......................................................................
Patch Set 1: Verified+1
unrelated test failures (DEBUG):
* DeleteTabletITest.TestNoMoreRetryWithWongServerUuid
* LogRollingITest.TestLogCleanupOnStartup
--
To view, visit http://gerrit.cloudera.org:8080/19784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae550774bd0aaf0b7bb8df7e64ee5b8b0fc22ac3
Gerrit-Change-Number: 19784
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Sat, 22 Apr 2023 00:11:02 +0000
Gerrit-HasComments: No
[kudu-CR] [client] add -Werror flag for checking client C++ API
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19784 )
Change subject: [client] add -Werror flag for checking client C++ API
......................................................................
[client] add -Werror flag for checking client C++ API
I noticed that many contemporary C++ compilers didn't error out but
issued a warning instead when compiling a code with C++11 features,
even if running with -std=c++98 flag.
To make the API compatibility check more robust, this patch adds -Werror
flag to make sure the client_examples-test.sh fails if incompatibility
is introduced into corresponding header files.
This is a follow-up to 10b1c30441dd48bebf692db8a41464cf08319908.
Change-Id: Iae550774bd0aaf0b7bb8df7e64ee5b8b0fc22ac3
Reviewed-on: http://gerrit.cloudera.org:8080/19784
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/client/client_examples-test.sh
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae550774bd0aaf0b7bb8df7e64ee5b8b0fc22ac3
Gerrit-Change-Number: 19784
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] [client] add -Werror flag for checking client C++ API
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19784 )
Change subject: [client] add -Werror flag for checking client C++ API
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae550774bd0aaf0b7bb8df7e64ee5b8b0fc22ac3
Gerrit-Change-Number: 19784
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Fri, 21 Apr 2023 23:41:14 +0000
Gerrit-HasComments: No
[kudu-CR] [client] add -Werror flag for checking client C++ API
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19784 )
Change subject: [client] add -Werror flag for checking client C++ API
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae550774bd0aaf0b7bb8df7e64ee5b8b0fc22ac3
Gerrit-Change-Number: 19784
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sun, 23 Apr 2023 09:39:58 +0000
Gerrit-HasComments: No