[GitHub] [ozone] timmylicheng commented on a change in pull request #1683: HDDS-4575: Refactor SCMHAManager and SCMRatisServer with RaftServer.Divison

[GitBox <gi...@apache.org>]

timmylicheng commented on a change in pull request #1683:
URL: https://github.com/apache/ozone/pull/1683#discussion_r542365071



##########
File path: hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/ha/MockSCMHAManager.java
##########
@@ -204,23 +180,27 @@ private Message process(final SCMRatisRequest request)
     }
 
     @Override
-    public RaftServer getServer() {
-      return null;
+    public void stop() {
     }
 
     @Override
-    public RaftGroupId getRaftGroupId() {
+    public RaftServer.Division getDivision() {
       return null;

Review comment:
       Do we allow Division to be null?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org