You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/03/17 09:30:42 UTC

[GitHub] [kylin] zzcclp commented on a change in pull request #1163: KYLIN-4423 fix bug: null input for EncryptUtil raise IllegalArgumentException

zzcclp commented on a change in pull request #1163: KYLIN-4423 fix bug: null input for EncryptUtil raise IllegalArgumentException
URL: https://github.com/apache/kylin/pull/1163#discussion_r393545950
 
 

 ##########
 File path: core-common/src/main/java/org/apache/kylin/common/util/EncryptUtil.java
 ##########
 @@ -32,6 +32,9 @@
             0x65, 0x79 };
 
     public static String encrypt(String strToEncrypt) {
+        if (strToEncrypt == null) {
 
 Review comment:
   it's better use 'org.apache.commons.lang3.StringUtils.isBlank' to check blank string case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services