You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by mm...@apache.org on 2020/12/04 18:02:32 UTC
[pulsar] branch master updated: Fix bit set recycle repeat in
client ack message (#8829)
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 1674c4c Fix bit set recycle repeat in client ack message (#8829)
1674c4c is described below
commit 1674c4c9460afcb3e4f422720a49fa108793d718
Author: congbo <39...@users.noreply.github.com>
AuthorDate: Sat Dec 5 02:02:11 2020 +0800
Fix bit set recycle repeat in client ack message (#8829)
Co-authored-by: congbo <co...@github.com>
---
.../src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java | 1 +
.../src/main/java/org/apache/pulsar/common/protocol/Commands.java | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
index 024ea3b1..d15010d 100644
--- a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
+++ b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
@@ -2426,6 +2426,7 @@ public class ConsumerImpl<T> extends ConsumerBase<T> implements ConnectionHandle
}
cmd = Commands.newAck(consumerId, ledgerId, entryId, bitSetRecyclable, ackType, validationError, properties,
txnID.getLeastSigBits(), txnID.getMostSigBits(), requestId, batchMessageId.getBatchSize());
+ bitSetRecyclable.recycle();
} else {
MessageIdImpl singleMessage = (MessageIdImpl) messageId;
ledgerId = singleMessage.getLedgerId();
diff --git a/pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java b/pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java
index dab7352..4b7936a 100644
--- a/pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java
+++ b/pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java
@@ -1162,7 +1162,6 @@ public class Commands {
messageIdDataBuilder.setEntryId(entryId);
if (ackSet != null) {
messageIdDataBuilder.addAllAckSet(SafeCollectionUtils.longArrayToList(ackSet.toLongArray()));
- ackSet.recycle();
}
if (batchSize >= 0) {