You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by qiuchenjian <gi...@git.apache.org> on 2018/12/26 13:37:15 UTC
[GitHub] carbondata pull request #3025: [CARBONDATA-3199]"show datamap" represents pr...
GitHub user qiuchenjian opened a pull request:
https://github.com/apache/carbondata/pull/3025
[CARBONDATA-3199]"show datamap" represents preaggregate datamap
[Problem] "show datamap" command doesn't represents preaggregate datamap, it only represents bloom filter datamap
[Solution]PreAggregateDataMapProvider save datamap schema on hdfs or s3, so that CarbonDataMapShowCommand can get all datamap
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
saveDataMapSchema
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/qiuchenjian/carbondata CARBONDATA-3199
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/3025.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3025
----
commit 29e08cc877a2c820520f1cafd8c2d098ba620012
Author: qiuchenjian <80...@...>
Date: 2018-12-26T13:32:24Z
[CARBONDATA-3199]"show datamap" represents preaggregate datamap
----
---
[GitHub] carbondata issue #3025: [CARBONDATA-3199]"show datamap" represents preaggreg...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3025
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2151/
---
[GitHub] carbondata issue #3025: [CARBONDATA-3199]"show datamap" represents preaggreg...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3025
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1942/
---
[GitHub] carbondata pull request #3025: [WIP][CARBONDATA-3199]"show datamap" represen...
Posted by qiuchenjian <gi...@git.apache.org>.
Github user qiuchenjian closed the pull request at:
https://github.com/apache/carbondata/pull/3025
---
[GitHub] carbondata issue #3025: [CARBONDATA-3199]"show datamap" represents preaggreg...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3025
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1945/
---
[GitHub] carbondata issue #3025: [CARBONDATA-3199]"show datamap" represents preaggreg...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3025
Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10195/
---
[GitHub] carbondata issue #3025: [CARBONDATA-3199]"show datamap" represents preaggreg...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3025
Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10198/
---
[GitHub] carbondata issue #3025: [WIP][CARBONDATA-3199]"show datamap" represents prea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3025
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1949/
---
[GitHub] carbondata issue #3025: [WIP][CARBONDATA-3199]"show datamap" represents prea...
Posted by qiuchenjian <gi...@git.apache.org>.
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/3025
> @qiuchenjian currently pre-aggregate datamap is not following the datamap interfaces as it was implemented before datamap framework. That is why not all datamap DDL works with pre-aggregate. It is better to keep the pre-aggregate datamap untouched in this area until we decide whether to take MV datamap or pre-aggregate datamap.
@ravipesala OK, I will close this PR. But "show datamap" can't return preaggregate ,but it's still called datamap, which is strange.
---
[GitHub] carbondata issue #3025: [WIP][CARBONDATA-3199]"show datamap" represents prea...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/3025
@qiuchenjian currently pre-aggregate datamap is not following the datamap interfaces as it was implemented before datamap framework. That is why not all datamap DDL works with pre-aggregate. It is better to keep the pre-aggregate datamap untouched in this area until we decide whether to take MV datamap or pre-aggregate datamap.
---
[GitHub] carbondata issue #3025: [CARBONDATA-3199]"show datamap" represents preaggreg...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3025
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2154/
---
[GitHub] carbondata issue #3025: [WIP][CARBONDATA-3199]"show datamap" represents prea...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3025
Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10202/
---
[GitHub] carbondata issue #3025: [CARBONDATA-3199]"show datamap" represents preaggreg...
Posted by qiuchenjian <gi...@git.apache.org>.
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/3025
retest this please
---