You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/11/18 22:04:31 UTC
[kudu-CR] [build] Fix LLVM build on Xcode 12.2
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16746
Change subject: [build] Fix LLVM build on Xcode 12.2
......................................................................
[build] Fix LLVM build on Xcode 12.2
When building with the latest Xcode version (12.2) I found thatL the LVVM
build failed to build sanitizer_platform_limits_posix.cpp due to the stats64
type missing. Given we don’t need the sanitizers, I disabled building them
to work around the issue.
Example error message:
kudu/thirdparty/src/llvm-9.0.0.src/projects/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cc:169:31: error: invalid application of 'sizeof' to an incomplete type 'struct stat64'
unsigned struct_stat64_sz = sizeof(struct stat64);
Change-Id: I17ea2de460aac4142469c95af201b17554c4f751
---
M thirdparty/build-definitions.sh
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/16746/1
--
To view, visit http://gerrit.cloudera.org:8080/16746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I17ea2de460aac4142469c95af201b17554c4f751
Gerrit-Change-Number: 16746
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [build] Fix LLVM build on Xcode 12.2
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16746 )
Change subject: [build] Fix LLVM build on Xcode 12.2
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
I was able to build LLVM with this patch.
Hitting some other issues with the Kudu build, but this at least helps get past building thirdparty.
http://gerrit.cloudera.org:8080/#/c/16746/2/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/16746/2/thirdparty/build-definitions.sh@290
PS2, Line 290: sanitzer_common
nit: sanitizer here too
http://gerrit.cloudera.org:8080/#/c/16746/2/thirdparty/build-definitions.sh@291
PS2, Line 291: github
Curious whether you tried disabling COMPILER_RT_HAS_SANITIZER_COMMON? Or would that be too broad a change?
--
To view, visit http://gerrit.cloudera.org:8080/16746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17ea2de460aac4142469c95af201b17554c4f751
Gerrit-Change-Number: 16746
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Nov 2020 23:55:28 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Fix LLVM build on Xcode 12.2
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16746 )
Change subject: [build] Fix LLVM build on Xcode 12.2
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/16746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17ea2de460aac4142469c95af201b17554c4f751
Gerrit-Change-Number: 16746
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Nov 2020 00:05:35 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Fix LLVM build on Xcode 12.2
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16746 )
Change subject: [build] Fix LLVM build on Xcode 12.2
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
I'm still using HighSierra (10.13.6) and Xcode 10.1, so I cannot check whether it fixes the issue with Xcode 12.2
http://gerrit.cloudera.org:8080/#/c/16746/2/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/16746/2/thirdparty/build-definitions.sh@290
PS2, Line 290: sanitzer_common
nit: sanitizer_common ?
--
To view, visit http://gerrit.cloudera.org:8080/16746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17ea2de460aac4142469c95af201b17554c4f751
Gerrit-Change-Number: 16746
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Nov 2020 23:57:27 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Fix LLVM build on Xcode 12.2
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16746 )
Change subject: [build] Fix LLVM build on Xcode 12.2
......................................................................
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/16746/2/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/16746/2/thirdparty/build-definitions.sh@287
PS2, Line 287: # Xcode 12.2 fails to buld the sanitzers and they are not needed.
> nit: sanitizers
Done
http://gerrit.cloudera.org:8080/#/c/16746/2/thirdparty/build-definitions.sh@290
PS2, Line 290: sanitzer_common
> nit: sanitizer here too
Done
http://gerrit.cloudera.org:8080/#/c/16746/2/thirdparty/build-definitions.sh@290
PS2, Line 290: sanitzer_common
> nit: sanitizer_common ?
Done
http://gerrit.cloudera.org:8080/#/c/16746/2/thirdparty/build-definitions.sh@291
PS2, Line 291: github
> Curious whether you tried disabling COMPILER_RT_HAS_SANITIZER_COMMON? Or wo
That isn't settable, it is set earlier in the LLVM build.
--
To view, visit http://gerrit.cloudera.org:8080/16746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17ea2de460aac4142469c95af201b17554c4f751
Gerrit-Change-Number: 16746
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Nov 2020 23:58:54 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Fix LLVM build on Xcode 12.2
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16746 )
Change subject: [build] Fix LLVM build on Xcode 12.2
......................................................................
[build] Fix LLVM build on Xcode 12.2
When building with the latest Xcode version (12.2) I found that the LLVM
build failed to build `sanitizer_platform_limits_posix.cpp` due to the `stat64`
type missing. Given we don’t need the sanitizers, I disabled building them
to work around the issue.
Example error message:
kudu/thirdparty/src/llvm-9.0.0.src/projects/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cc:169:31: error: invalid application of 'sizeof' to an incomplete type 'struct stat64'
unsigned struct_stat64_sz = sizeof(struct stat64);
Change-Id: I17ea2de460aac4142469c95af201b17554c4f751
Reviewed-on: http://gerrit.cloudera.org:8080/16746
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
---
M thirdparty/build-definitions.sh
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, but someone else must approve
Andrew Wong: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/16746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I17ea2de460aac4142469c95af201b17554c4f751
Gerrit-Change-Number: 16746
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] [build] Fix LLVM build on Xcode 12.2
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16746 )
Change subject: [build] Fix LLVM build on Xcode 12.2
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
I'm running through a build on macOS 10.15.4 with XCode 12.2
http://gerrit.cloudera.org:8080/#/c/16746/2/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/16746/2/thirdparty/build-definitions.sh@287
PS2, Line 287: # Xcode 12.2 fails to buld the sanitzers and they are not needed.
nit: sanitizers
--
To view, visit http://gerrit.cloudera.org:8080/16746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17ea2de460aac4142469c95af201b17554c4f751
Gerrit-Change-Number: 16746
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Nov 2020 22:27:28 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Fix LLVM build on Xcode 12.2
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16746
to look at the new patch set (#2).
Change subject: [build] Fix LLVM build on Xcode 12.2
......................................................................
[build] Fix LLVM build on Xcode 12.2
When building with the latest Xcode version (12.2) I found that the LLVM
build failed to build `sanitizer_platform_limits_posix.cpp` due to the `stat64`
type missing. Given we don’t need the sanitizers, I disabled building them
to work around the issue.
Example error message:
kudu/thirdparty/src/llvm-9.0.0.src/projects/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cc:169:31: error: invalid application of 'sizeof' to an incomplete type 'struct stat64'
unsigned struct_stat64_sz = sizeof(struct stat64);
Change-Id: I17ea2de460aac4142469c95af201b17554c4f751
---
M thirdparty/build-definitions.sh
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/16746/2
--
To view, visit http://gerrit.cloudera.org:8080/16746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I17ea2de460aac4142469c95af201b17554c4f751
Gerrit-Change-Number: 16746
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Fix LLVM build on Xcode 12.2
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16746 )
Change subject: [build] Fix LLVM build on Xcode 12.2
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17ea2de460aac4142469c95af201b17554c4f751
Gerrit-Change-Number: 16746
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Nov 2020 00:05:57 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Fix LLVM build on Xcode 12.2
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16746
to look at the new patch set (#3).
Change subject: [build] Fix LLVM build on Xcode 12.2
......................................................................
[build] Fix LLVM build on Xcode 12.2
When building with the latest Xcode version (12.2) I found that the LLVM
build failed to build `sanitizer_platform_limits_posix.cpp` due to the `stat64`
type missing. Given we don’t need the sanitizers, I disabled building them
to work around the issue.
Example error message:
kudu/thirdparty/src/llvm-9.0.0.src/projects/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cc:169:31: error: invalid application of 'sizeof' to an incomplete type 'struct stat64'
unsigned struct_stat64_sz = sizeof(struct stat64);
Change-Id: I17ea2de460aac4142469c95af201b17554c4f751
---
M thirdparty/build-definitions.sh
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/16746/3
--
To view, visit http://gerrit.cloudera.org:8080/16746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I17ea2de460aac4142469c95af201b17554c4f751
Gerrit-Change-Number: 16746
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>