You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/08/10 21:00:08 UTC
[kudu-CR] test result server: improve indexes, add sorting
Hello Mike Percy, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3889
to review the following change.
Change subject: test_result_server: improve indexes, add sorting
......................................................................
test_result_server: improve indexes, add sorting
* adds a new index to the underlying database table.
I applied this by hand in production and page loads that used to take several
seconds are now quite fast.
* uses the 'DataTables' jQuery plugin to make the main list of flaky tests
sortable by flaky rate.
Tested manually by running this locally against the production database.
Change-Id: I4f4321ad01d8e5fe83276d07cd6d6025dab5518e
---
M build-support/test_result_server.py
1 file changed, 29 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/3889/1
--
To view, visit http://gerrit.cloudera.org:8080/3889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f4321ad01d8e5fe83276d07cd6d6025dab5518e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] test result server: improve indexes, add sorting
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: test_result_server: improve indexes, add sorting
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3889/1/build-support/test_result_server.py
File build-support/test_result_server.py:
Line 146: INDEX (test_name, timestamp),
Why don't we need the revision index anymore?
--
To view, visit http://gerrit.cloudera.org:8080/3889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f4321ad01d8e5fe83276d07cd6d6025dab5518e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] test result server: improve indexes, add sorting
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: test_result_server: improve indexes, add sorting
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3889/1/build-support/test_result_server.py
File build-support/test_result_server.py:
Line 146: INDEX (test_name, timestamp),
> Why don't we need the revision index anymore?
I didn't see any cases where we had a 'WHERE revision = ...', not sure why we had that index in the first place.
--
To view, visit http://gerrit.cloudera.org:8080/3889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f4321ad01d8e5fe83276d07cd6d6025dab5518e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] test result server: improve indexes, add sorting
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: test_result_server: improve indexes, add sorting
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f4321ad01d8e5fe83276d07cd6d6025dab5518e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] test result server: improve indexes, add sorting
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: test_result_server: improve indexes, add sorting
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2801/
--
To view, visit http://gerrit.cloudera.org:8080/3889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f4321ad01d8e5fe83276d07cd6d6025dab5518e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] test result server: improve indexes, add sorting
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: test_result_server: improve indexes, add sorting
......................................................................
test_result_server: improve indexes, add sorting
* adds a new index to the underlying database table.
I applied this by hand in production and page loads that used to take several
seconds are now quite fast.
* uses the 'DataTables' jQuery plugin to make the main list of flaky tests
sortable by flaky rate.
Tested manually by running this locally against the production database.
Change-Id: I4f4321ad01d8e5fe83276d07cd6d6025dab5518e
Reviewed-on: http://gerrit.cloudera.org:8080/3889
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Todd Lipcon <to...@apache.org>
---
M build-support/test_result_server.py
1 file changed, 29 insertions(+), 13 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Todd Lipcon: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f4321ad01d8e5fe83276d07cd6d6025dab5518e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] test result server: improve indexes, add sorting
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: test_result_server: improve indexes, add sorting
......................................................................
Patch Set 2:
(I deployed this)
--
To view, visit http://gerrit.cloudera.org:8080/3889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f4321ad01d8e5fe83276d07cd6d6025dab5518e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No