You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/19 12:54:46 UTC
[GitHub] [airflow] ryanahamilton opened a new pull request #8912: UX Fix: Prevent undesired text selection with DAG title selection
ryanahamilton opened a new pull request #8912:
URL: https://github.com/apache/airflow/pull/8912
Prevent undesired text selection (in Chrome browser) when DAG title is double-click selected.
Simply utilizes `user-select: none;` CSS on the label to prevent its selection.
**Behavior before:**
**Behavior after:**
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] loociano commented on pull request #8912: UX Fix: Prevent undesired text selection with DAG title selection in Chrome
Posted by GitBox <gi...@apache.org>.
loociano commented on pull request #8912:
URL: https://github.com/apache/airflow/pull/8912#issuecomment-879917922
> @loociano [1663760](https://github.com/apache/airflow/commit/1663760ea8d5853d8c6cc1cc9ce54306bfddc1c2) is the commit that is included in 1.10.11
My bad, I was looking into `airflow/www/templates/airflow/dag.html`, however the fix is in `airflow/www_rbac/templates/airflow/dag.html`
@ashb do you know the difference between `www` and `www_rbac`? Should the fix be included in both?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #8912: UX Fix: Prevent undesired text selection with DAG title selection
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #8912:
URL: https://github.com/apache/airflow/pull/8912#issuecomment-630808672
Is it worth doing `user-select:none; -moz-user-select: auto` so it stays working in FF, since this is a chrome only bug?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] loociano commented on pull request #8912: UX Fix: Prevent undesired text selection with DAG title selection in Chrome
Posted by GitBox <gi...@apache.org>.
loociano commented on pull request #8912:
URL: https://github.com/apache/airflow/pull/8912#issuecomment-879806435
An alternative fix that does not use `user-select:none; -moz-user-select: auto;` would be to remove the `<div>` that wraps the headings used for DAG name and schedule.
Before:
```
<div>
<h3> ...DAG name code... </h3>
<h4> ...Schedule code... </h4>
<div>
<div class="clearfix"></div>
```
After:
```
<h3> ...DAG name code... </h3>
<h4> ...Schedule code... </h4>
<div class="clearfix"></div>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #8912: UX Fix: Prevent undesired text selection with DAG title selection in Chrome
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #8912:
URL: https://github.com/apache/airflow/pull/8912#issuecomment-879891278
@loociano https://github.com/apache/airflow/commit/1663760ea8d5853d8c6cc1cc9ce54306bfddc1c2 is the commit that is included in 1.10.11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #8912: UX Fix: Prevent undesired text selection with DAG title selection
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #8912:
URL: https://github.com/apache/airflow/pull/8912#issuecomment-630804755
I guess that means that the schedule is now not selectable at all? Hmmm. Stupid Chrome making us make decisions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] loociano edited a comment on pull request #8912: UX Fix: Prevent undesired text selection with DAG title selection in Chrome
Posted by GitBox <gi...@apache.org>.
loociano edited a comment on pull request #8912:
URL: https://github.com/apache/airflow/pull/8912#issuecomment-879888350
I was first wondering why this issue is still occurring a year later.
Despite #8912 being listed in [1.10.11](https://github.com/apache/airflow/releases/tag/1.10.11), @ryanahamilton's fix is not included in the release code (not even in 1.10.15). Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on pull request #8912: UX Fix: Prevent undesired text selection with DAG title selection
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on pull request #8912:
URL: https://github.com/apache/airflow/pull/8912#issuecomment-630816496
@ashb that's a good idea… I tend to avoid vendor prefixes when possible, but in this case we'd be utilizing it to undo a hack. The `user-select: none` doesn't affect Safari, so the behavior is already as desired there. Will update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #8912: UX Fix: Prevent undesired text selection with DAG title selection in Chrome
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #8912:
URL: https://github.com/apache/airflow/pull/8912
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #8912: UX Fix: Prevent undesired text selection with DAG title selection in Chrome
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #8912:
URL: https://github.com/apache/airflow/pull/8912#issuecomment-879938049
In 1.10, `www` is the classic/deprecated UI, and hasn't been recieving fixes for a while (since ~1.10.6), www_rbac is what _becomes_ the `www` in 2.0, and can be enabled on 1.10 releases by setting `rbac = True` in the airflow.cfg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] loociano commented on pull request #8912: UX Fix: Prevent undesired text selection with DAG title selection in Chrome
Posted by GitBox <gi...@apache.org>.
loociano commented on pull request #8912:
URL: https://github.com/apache/airflow/pull/8912#issuecomment-879888350
I was first wondering why this issue is still occurring a year later.
Despite #8912 being listed in [1.10.11](https://github.com/apache/airflow/releases/tag/1.10.11), @ryanahamilton's fix is not included in the release code (not even in 1.10.15).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on pull request #8912: UX Fix: Prevent undesired text selection with DAG title selection
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on pull request #8912:
URL: https://github.com/apache/airflow/pull/8912#issuecomment-630807001
@ashb yeah, it's a trade-off. The schedule link is still clickable/functional. The DAG title certainly seems like the more likely element for a user to want to select.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #8912: UX Fix: Prevent undesired text selection with DAG title selection in Chrome
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #8912:
URL: https://github.com/apache/airflow/pull/8912#issuecomment-879807022
@loociano PR welcome 😁
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org