You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/03 21:51:21 UTC
[GitHub] [incubator-superset] willbarrett opened a new pull request #9078:
Wrap tagging endpoints in a feature flag (disabled by default)
willbarrett opened a new pull request #9078: Wrap tagging endpoints in a feature flag (disabled by default)
URL: https://github.com/apache/incubator-superset/pull/9078
### CATEGORY
Choose one
- [ ] Bug Fix
- [X] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Currently the tagging system only has a back-end that's part of the Superset codebase. We would like to be able to disable these endpoints inside of Preset until a front-end is adopted. In order to do that, I have added a feature flag to selectively enable the endpoints provided by `TagView`. I believe this change will primarily impact the deployment at Lyft (@betodealmeida @DiggidyDave)
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
N/A
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
- CI
- Ensure endpoints supplied by `TagView` are not accessible after the change by default
- Enable the `TAGGING_ENDPONTS` feature flag and ensure the endpoints supplied by `TagView` are operational.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [X] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@betodealmeida @DiggidyDave @dpgaspar @craig-rueda
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] craig-rueda commented on a change in pull
request #9078: Wrap tagging endpoints in a feature flag (disabled by default)
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on a change in pull request #9078: Wrap tagging endpoints in a feature flag (disabled by default)
URL: https://github.com/apache/incubator-superset/pull/9078#discussion_r374364804
##########
File path: superset/app.py
##########
@@ -277,7 +277,9 @@ def init_views(self) -> None:
appbuilder.add_view_no_menu(TableModelView)
appbuilder.add_view_no_menu(TableSchemaView)
appbuilder.add_view_no_menu(TabStateView)
- appbuilder.add_view_no_menu(TagView)
+
+ if feature_flag_manager.is_feature_enabled("TAGGING_ENDPOINTS"):
Review comment:
Would be great to add a test for this, although it's not trivial to do so with our current testing setup :,(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9078: Wrap
tagging endpoints in a feature flag (disabled by default)
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9078: Wrap tagging endpoints in a feature flag (disabled by default)
URL: https://github.com/apache/incubator-superset/pull/9078#issuecomment-581643507
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9078?src=pr&el=h1) Report
> Merging [#9078](https://codecov.io/gh/apache/incubator-superset/pull/9078?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/540df268c286d454ad3980f5c38a972d2163344f?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9078?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9078 +/- ##
=======================================
Coverage 59.45% 59.45%
=======================================
Files 369 369
Lines 11752 11752
Branches 2889 2889
=======================================
Hits 6987 6987
Misses 4586 4586
Partials 179 179
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9078?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9078?src=pr&el=footer). Last update [540df26...a2e4855](https://codecov.io/gh/apache/incubator-superset/pull/9078?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9078:
Wrap tagging endpoints in a feature flag (disabled by default)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9078: Wrap tagging endpoints in a feature flag (disabled by default)
URL: https://github.com/apache/incubator-superset/pull/9078#issuecomment-581643507
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9078?src=pr&el=h1) Report
> Merging [#9078](https://codecov.io/gh/apache/incubator-superset/pull/9078?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/540df268c286d454ad3980f5c38a972d2163344f?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9078?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9078 +/- ##
=======================================
Coverage 59.45% 59.45%
=======================================
Files 369 369
Lines 11752 11752
Branches 2889 2889
=======================================
Hits 6987 6987
Misses 4586 4586
Partials 179 179
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9078?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9078?src=pr&el=footer). Last update [540df26...9f086ae](https://codecov.io/gh/apache/incubator-superset/pull/9078?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] craig-rueda merged pull request #9078: Wrap
tagging endpoints in a feature flag (disabled by default)
Posted by GitBox <gi...@apache.org>.
craig-rueda merged pull request #9078: Wrap tagging endpoints in a feature flag (disabled by default)
URL: https://github.com/apache/incubator-superset/pull/9078
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9078:
Wrap tagging endpoints in a feature flag (disabled by default)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9078: Wrap tagging endpoints in a feature flag (disabled by default)
URL: https://github.com/apache/incubator-superset/pull/9078#issuecomment-581643507
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9078?src=pr&el=h1) Report
> Merging [#9078](https://codecov.io/gh/apache/incubator-superset/pull/9078?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/540df268c286d454ad3980f5c38a972d2163344f?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9078?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9078 +/- ##
=======================================
Coverage 59.45% 59.45%
=======================================
Files 369 369
Lines 11752 11752
Branches 2889 2889
=======================================
Hits 6987 6987
Misses 4586 4586
Partials 179 179
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9078?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9078?src=pr&el=footer). Last update [540df26...9f086ae](https://codecov.io/gh/apache/incubator-superset/pull/9078?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on issue #9078: Wrap
tagging endpoints in a feature flag (disabled by default)
Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #9078: Wrap tagging endpoints in a feature flag (disabled by default)
URL: https://github.com/apache/incubator-superset/pull/9078#issuecomment-581680502
Aha! Thanks @etr2460 I'll reuse the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org