You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Joseph Wu (JIRA)" <ji...@apache.org> on 2018/02/07 03:27:00 UTC

[jira] [Commented] (MESOS-2487) Ensure protobuf "==" operator does not go out of sync with new protobuf fields

    [ https://issues.apache.org/jira/browse/MESOS-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16354905#comment-16354905 ] 

Joseph Wu commented on MESOS-2487:
----------------------------------

Playing around with what the code might look like with this class:
https://reviews.apache.org/r/65541/

> Ensure protobuf "==" operator does not go out of sync with new protobuf fields
> ------------------------------------------------------------------------------
>
>                 Key: MESOS-2487
>                 URL: https://issues.apache.org/jira/browse/MESOS-2487
>             Project: Mesos
>          Issue Type: Task
>            Reporter: Vinod Kone
>            Priority: Major
>
> Currently when a new field is added to a protobuf that has a custom "==" operator defined,  we don't make sure that the field is accounted for in the comparison. Ideally we should catch such errors at build time or 'make check' time. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)