[jira] Commented: (WODEN-20) Component model API needs modifiers

["Arthur Ryman (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WODEN-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865265#action_12865265 ] 

Arthur Ryman commented on WODEN-20:
-----------------------------------

Dilshan, nice writeup. I have a few comments.

1. Naming if new interfaces. You prefixed all the component model names with "Editable" which makes them long. Perhaps you could keep the existing names, but but them in a new "editable" package.

2. The file serialization strategy relies and naming conventions to generate the file names. This means you can't handle the important use case of editing an existing set of WSDL 2.0 files. Suppose you start with a set of WSDL 2.0 files and want to modify them. You should serialize them back into the same files. This works unless the user creates new top-level components. In this case the user should be able to specify the name of the file. So I think the interface for creating a new top-level component should let to specify the name the file, or maybe an output stream.

> Component model API needs modifiers
> -----------------------------------
>
>                 Key: WODEN-20
>                 URL: https://issues.apache.org/jira/browse/WODEN-20
>             Project: Woden
>          Issue Type: New Feature
>          Components: Parser
>            Reporter: Jeremy Hughes
>            Assignee: Sagara Gunathunga 
>         Attachments: WodenProposal_Dilshan.pdf
>
>
> A Woden 'client' - eg a tool such as java2wsdl - might want to:
> 1 introspect a tree of java classes / interfaces
> 2 create an org.apache.woden.wsdl20.Interface for each - adding to the Description object along the way
> 3 serialize to disk.
> Today it is only possible to modify the object form of the WSDL through the Element model API. This requires the client app to understand WSDL at the file level.
> For step 2 addInterface() is required on Description. Of course Interface.addInterfaceOperation() is then required and so on...
> For step 3 a 'strategy' is needed to map from the Component model to the Element model's representation of the WSDL in file form. e.g. do all the <interface> elements go in the same WSDL file or do all the <interface> elements in the same namespace go in one file etc. Also, do the <service> elements go in separately included/imported WSDL files as is typically the best practice with WSDL 1.1. All these options could be represented using a strategy pattern. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org