You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/09 13:50:30 UTC

[GitHub] [skywalking] qxo commented on pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm

qxo commented on pull request #5274:
URL: https://github.com/apache/skywalking/pull/5274#issuecomment-671054409


   > You should make the codes detecting the JVM type automatically. And your codes include a lot try catch and reflection. Why do you write codes in this way?
   
   Cause I don't want my code depends on oracle/sun jvm api (com.sun.management.OperatingSystemMXBean)  or ibm jvm api （com.ibm.lang.management.OperatingSystemMXBean）。
   With reflection we support  oracle/sun and ibm jvm and maybe other jvm :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org