You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/05/11 03:38:10 UTC

[GitHub] zheng-da commented on a change in pull request #10888: Fix thread local.

zheng-da commented on a change in pull request #10888: Fix thread local.
URL: https://github.com/apache/incubator-mxnet/pull/10888#discussion_r187513562
 
 

 ##########
 File path: src/operator/nn/deconvolution.cu
 ##########
 @@ -40,9 +40,15 @@ static CuDNNDeconvolutionOp<DType> &GetCuDNNDeconvOp(const DeconvolutionParam& p
                                                      const std::vector<TShape>& in_shape,
                                                      const std::vector<TShape>& out_shape,
                                                      const RunContext& rctx) {
+#if DMLC_CXX11_THREAD_LOCAL
 
 Review comment:
   not entirely sure. but the way we are using right now is to use MX_THREAD_LOCAL and thread_local depending on the macro.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services