You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:40:10 UTC

[GitHub] [incubator-echarts] plainheart opened a new pull request #12780: fix(bmap): removed ES5 in bmap extension.

plainheart opened a new pull request #12780:
URL: https://github.com/apache/incubator-echarts/pull/12780


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [ ] new feature
   - [x] others
   
   
   
   ### What does this PR do?
   
   According to [Coding Standard](https://echarts.apache.org/en/coding-standard.html#language-features), ES5 shouldn't be used. This PR removed related usage.
   
   ## Details
   
   ### Before: What was the problem?
   
   `Object.keys` which belongs to ES5 is used in source code.
   
   ![image](https://user-images.githubusercontent.com/26999792/84132905-029f9900-aa79-11ea-83da-be27c723ad43.png)
   
   
   ### After: How is it fixed in this PR?
   
   Added a function named `isEmptyObject` as the substitution for `Object.keys`
   ```js
   function isEmptyObject(obj) {
       for (var key in obj) {
           if (obj.hasOwnProperty(key)) {
               return false;
           }
       }
       return true;
   }
   ```
   
   ![image](https://user-images.githubusercontent.com/26999792/84133555-e18b7800-aa79-11ea-8bab-f6ad0d445d0a.png)
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [x] The API has been changed.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12780: fix(bmap): removed ES5 in bmap extension.

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #12780:
URL: https://github.com/apache/incubator-echarts/pull/12780#issuecomment-642389059


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] pissang merged pull request #12780: fix(bmap): removed ES5 in bmap extension.

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #12780:
URL: https://github.com/apache/incubator-echarts/pull/12780


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12780: fix(bmap): removed ES5 in bmap extension.

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #12780:
URL: https://github.com/apache/incubator-echarts/pull/12780#issuecomment-641179436


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org