You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/04/25 23:05:15 UTC
[GitHub] [incubator-druid] himanshug commented on issue #7206: Add the
pull-request template
himanshug commented on issue #7206: Add the pull-request template
URL: https://github.com/apache/incubator-druid/pull/7206#issuecomment-486868529
this should take http://mail-archives.apache.org/mod_mbox/druid-dev/201904.mbox/browser into consideration, and we should conclude something on that thread.
I am not clear what are the "must haves" that would be enforced in each and every PR. Others should not be used to block a PR or else that is unfair to that PR's author.
My fear is that Long list of things will further the discrepancy among reviewers leading to some PRs getting stuck because they happened to be reviewed by certain reviewers vs others.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org