You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/12 22:57:33 UTC

[GitHub] [pulsar-client-go] dferstay opened a new pull request #280: Expose BatchingMaxSize from ProducerOptions

dferstay opened a new pull request #280:
URL: https://github.com/apache/pulsar-client-go/pull/280


   Previously, the producer maximum batch size was hard-coded to 128 KB.
   
   Now, the produdcer maximum batch size is exposed via ProducerOptions
   and defaults to 128 KB
   
   ### Motivation
   
   Different applications producing to Pulsar require different batching policies.
   Previously, users had control over the maximum batching delay and the maximum number of messages in a batch, but could not control the maximum number of bytes in a batch.  This change enables the latter. 
   
   ### Modifications
   
   Expose a new `ProducerOption.BatchingMaxSize` (default: 128KB) that allows the user to configure the maximum batch size.  This option has been plumbed through `partition_producer` module to the `internal/batch_builder` module where it is used.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is already covered by existing tests, such as `producer_test.TestFlushInPartitionedProducer` and `producer_test.TestFlushInProducer`.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - The public API: The pulsar.ProducerOptions structure gains a new field: `BatchingMaxSize` 
   
   ### Documentation
   
     - Does this pull request introduce a new feature? Yes
     - If yes, how is the feature documented? GoDocs


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] merlimat merged pull request #280: Expose BatchingMaxSize from ProducerOptions

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #280:
URL: https://github.com/apache/pulsar-client-go/pull/280


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org