[GitHub] [cloudstack] rhtyd opened a new pull request #3468: network: allow icmp code 16 in firewall rules

[GitBox <gi...@apache.org>]

rhtyd opened a new pull request #3468: network: allow icmp code 16 in firewall rules
URL: https://github.com/apache/cloudstack/pull/3468
 
 
   This allows for icmp code range 0-16.
   
   Type 9 Router advertisement reference:
   https://www.iana.org/assignments/icmp-parameters/icmp-parameters.xhtml#icmp-parameters-codes-9/#table-icmp-parameters-ext-classes
   
   Fixes #3349
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services