[GitHub] [arrow] jonkeane commented on pull request #12622: ARROW-15802 [R] bindings for lubridate::make_datetime() and lubridate::make_date()

[GitBox <gi...@apache.org>]

jonkeane commented on pull request #12622:
URL: https://github.com/apache/arrow/pull/12622#issuecomment-1069237560


   > The are some outstanding issues, mostly having to do with the timezone argument:
   >
   > 1. default values:
   > for ISOdate() the default value is "GMT" which, in fact, is "UTC".
   I think this is fine, we can make ours just be `"UTC"` it's most important to match behavior even if it means our signatures are slightly different.
   
   > for ISOdatetime() the default value is "" (current timezone)
   This is similar to our other issue with needing to add a TZ in arrow if we have "". Can we leave it as is and will that automagically become fixed when that other ticket is done? Speaking of: what _is_ the status of that other ticket?
   
   > for lubridate::make_datetime() the default value is "UTC"
   This is ok, right?
   
   
   > 2. the strptime binding does not support the tz argument - pointing to [ARROW-12820](https://issues.apache.org/jira/browse/ARROW-12820) - which is now solved. I have a feeling that issue doesn't actually mean we can now switch on tz support in strptime.
   Yes, though for this binding you can actually "just" specify the timezone after you do the `strptime`, no?
   
   > For 1, the solution could be to set the default value for all tz args to "UTC".
   Yup!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org