[GitHub] [skywalking] mrproliu commented on a change in pull request #8193: Introduce the Customized ALS Protocol for Satellite

[GitBox <gi...@apache.org>]

mrproliu commented on a change in pull request #8193:
URL: https://github.com/apache/skywalking/pull/8193#discussion_r757827902



##########
File path: oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/AccessLogServiceGRPCHandler.java
##########
@@ -105,7 +110,7 @@ public AccessLogServiceGRPCHandler(ModuleManager manager,
             public void onNext(StreamAccessLogsMessage message) {
                 HistogramMetrics.Timer timer = histogram.createTimer();
                 try {
-                    if (isFirst) {
+                    if (isFirst || (alwaysAnalyzeIdentity && message.getIdentifier() != null)) {

Review comment:
       > If @mrproliu you had experimented this, can you just post the so11y metrics (especially CPU) of OAP before and after the new protocol?
   
   I could not happen on this, because it decides by the satellite message package mechanism. Only the first message in the batch could have the identity.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org