You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by jwagenleitner <gi...@git.apache.org> on 2016/04/23 08:14:36 UTC
[GitHub] groovy pull request: JSON refactoring/cleanup
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/318
JSON refactoring/cleanup
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jwagenleitner/groovy json-refactor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/groovy/pull/318.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #318
----
commit e968f2b83132dc6a75fbb07d75c1e1af7b143070
Author: John Wagenleitner <jw...@apache.org>
Date: 2016-04-23T05:53:51Z
refactor(json): remove final modifier from private methods
Since private methods cannot be meaningfully overridden, declaring them final is redundant and can be confusing to those reviewing the code.
commit 92944edac0e3e15f38ff1bad3701df4330d6760b
Author: John Wagenleitner <jw...@apache.org>
Date: 2016-04-23T06:04:11Z
refactor(json): simplified expressions
commit 48fa97e2ebbc29c369a9b66a9dfbf491208294dc
Author: John Wagenleitner <jw...@apache.org>
Date: 2016-04-23T06:08:34Z
refactor(json): inline to eliminate unused Classes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] groovy pull request: JSON refactoring/cleanup
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/318
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---