You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Thejas Nair <th...@hortonworks.com> on 2014/04/03 03:30:04 UTC

Re: Review Request 19979: sql std auth - database authorization does not check for role ownership

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19979/
-----------------------------------------------------------

(Updated April 3, 2014, 1:30 a.m.)


Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-6823
    https://issues.apache.org/jira/browse/HIVE-6823


Repository: hive-git


Description
-------

A role can own the database, but when the authorization checks are determining the privileges for a user, they are not checking if one of the roles the user belongs to is an owner of the database.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLAuthorizationUtils.java 95da54a 
  ql/src/test/queries/clientpositive/authorization_owner_actions_db.q PRE-CREATION 
  ql/src/test/results/clientpositive/authorization_owner_actions_db.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/19979/diff/


Testing
-------

new tests included.


Thanks,

Thejas Nair