You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Julian Reschke (Jira)" <ji...@apache.org> on 2020/03/24 15:13:00 UTC
[jira] [Commented] (OAK-8657) SimpleCredentialsSupport uses Guava
API in exported API
[ https://issues.apache.org/jira/browse/OAK-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065871#comment-17065871 ]
Julian Reschke commented on OAK-8657:
-------------------------------------
FWIW, the changes for OAK-7358 proved to be harder to get accepted in the downstream project than expected, so I (reluctantly) left his change out.
> SimpleCredentialsSupport uses Guava API in exported API
> -------------------------------------------------------
>
> Key: OAK-8657
> URL: https://issues.apache.org/jira/browse/OAK-8657
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Components: security-spi
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Blocker
> Fix For: 1.28.0
>
>
> {noformat}
> @Override
> @NotNull
> public ImmutableSet<Class> getCredentialClasses() {
> return ImmutableSet.<Class>of(SimpleCredentials.class);
> }
> {noformat}
> We should fix this to use a regular `Set` (as in the implemented interface). However, this would be an incompatible API change; we could do that in sync with OAK-7358.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)