You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by pi...@apache.org on 2017/10/26 21:03:07 UTC
[royale-asjs] branch develop updated: Fix issue where link has not
been used by FooterLinkItemRenderer
This is an automated email from the ASF dual-hosted git repository.
piotrz pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new ad2701b Fix issue where link has not been used by FooterLinkItemRenderer
ad2701b is described below
commit ad2701bceba090d6f3b74aedbedb564fa48ce6a9
Author: Piotr Zarzycki <pi...@gmail.com>
AuthorDate: Thu Oct 26 23:03:00 2017 +0200
Fix issue where link has not been used by FooterLinkItemRenderer
---
.../mdl/itemRenderers/FooterLinkItemRenderer.as | 39 +++++++++++-----------
1 file changed, 19 insertions(+), 20 deletions(-)
diff --git a/frameworks/projects/MaterialDesignLite/src/main/royale/org/apache/royale/mdl/itemRenderers/FooterLinkItemRenderer.as b/frameworks/projects/MaterialDesignLite/src/main/royale/org/apache/royale/mdl/itemRenderers/FooterLinkItemRenderer.as
index babab26..d6e895e 100644
--- a/frameworks/projects/MaterialDesignLite/src/main/royale/org/apache/royale/mdl/itemRenderers/FooterLinkItemRenderer.as
+++ b/frameworks/projects/MaterialDesignLite/src/main/royale/org/apache/royale/mdl/itemRenderers/FooterLinkItemRenderer.as
@@ -103,8 +103,7 @@ package org.apache.royale.mdl.itemRenderers
override public function set data(value:Object):void
{
super.data = value;
-
- var text:String;
+
if (labelField || dataField) {
text = String(value[labelField]);
} else {
@@ -113,20 +112,20 @@ package org.apache.royale.mdl.itemRenderers
COMPILE::JS
{
- if(textNode != null)
- {
- textNode.nodeValue = text;
- }
+ if(textNode != null)
+ {
+ textNode.nodeValue = text;
+ }
- if (a != null)
+ if (link != null)
{
- (a as HTMLElement).setAttribute('href', href);
+ (link as HTMLElement).setAttribute('href', href);
}
}
}
- COMPILE::JS
- private var a:HTMLElement;
+ COMPILE::JS
+ private var link:HTMLElement;
/**
* @royaleignorecoercion org.apache.royale.core.WrappedHTMLElement
@@ -136,18 +135,18 @@ package org.apache.royale.mdl.itemRenderers
COMPILE::JS
override protected function createElement():WrappedHTMLElement
{
- addElementToWrapper(this,'li');
-
- var a:HTMLElement = document.createElement('a') as HTMLElement;
- a.setAttribute('href', href);
+ addElementToWrapper(this,'li');
- element.appendChild(a);
+ link = document.createElement('a') as HTMLElement;
+ link.setAttribute('href', href);
- if(MXMLDescriptor == null)
- {
- textNode = document.createTextNode('') as Text;
- a.appendChild(textNode);
- }
+ element.appendChild(link);
+
+ if(MXMLDescriptor == null)
+ {
+ textNode = document.createTextNode('') as Text;
+ link.appendChild(textNode);
+ }
return element;
}
}
--
To stop receiving notification emails like this one, please contact
['"commits@royale.apache.org" <co...@royale.apache.org>'].