You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltacloud.apache.org by sa...@eucalyptus.com on 2011/08/19 23:03:41 UTC

[PATCH] fix a bug in Eucalyptus' delete_firewall_rule

From: Sang-Min Park <sp...@eucalyptus.com>

---
 .../drivers/eucalyptus/eucalyptus_driver.rb        |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/server/lib/deltacloud/drivers/eucalyptus/eucalyptus_driver.rb b/server/lib/deltacloud/drivers/eucalyptus/eucalyptus_driver.rb
index ceb2ff1..721defd 100644
--- a/server/lib/deltacloud/drivers/eucalyptus/eucalyptus_driver.rb
+++ b/server/lib/deltacloud/drivers/eucalyptus/eucalyptus_driver.rb
@@ -144,7 +144,7 @@ module Deltacloud
 
         def delete_firewall_rule(credentials, opts={})
           ec2 = new_client(credentials)
-          firewall = opts[:id]
+          firewall = opts[:firewall]
           protocol, from_port, to_port, addresses, groups = firewall_rule_params(opts[:rule_id])
           unless groups.nil?
             groups.each_index do |i|
-- 
1.7.4.1


Re: [PATCH] fix a bug in Eucalyptus' delete_firewall_rule

Posted by David Lutterkort <lu...@redhat.com>.
On Fri, 2011-08-19 at 14:03 -0700, sang-min.park@eucalyptus.com wrote:
> From: Sang-Min Park <sp...@eucalyptus.com>
> 
> ---
>  .../drivers/eucalyptus/eucalyptus_driver.rb        |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

ACK. I also pushed the patch already.

David