You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/04/08 01:37:08 UTC

[kudu-CR] [tests] make one scenario of client-test more stable

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18396


Change subject: [tests] make one scenario of client-test more stable
......................................................................

[tests] make one scenario of client-test more stable

This patch makes ClientTest.TestScannerKeepAlive more stable.

The motivation for this patch was seeing the following test
failure in a TSAN build [1]:

  src/kudu/client/client-test.cc:2763
  Failed
  Bad status: Not found: Scanner 0d9072070e4443ba8c49b089806415b4 not found (it may have expired)

Before: 2 out of 32 failed
  http://dist-test.cloudera.org/job?job_id=aserbin.1649379879.23423

After:  0 out of 32 failed
  http://dist-test.cloudera.org/job?job_id=aserbin.1649381490.37476

[1] http://jenkins.kudu.apache.org/job/kudu-gerrit/25299/BUILD_TYPE=TSAN

Change-Id: Ia7ebddc5499d59e37282e4f1e6513bc5f83cdb8a
---
M src/kudu/client/client-test.cc
1 file changed, 10 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/18396/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7ebddc5499d59e37282e4f1e6513bc5f83cdb8a
Gerrit-Change-Number: 18396
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [tests] make one scenario of client-test more stable

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [tests] make one scenario of client-test more stable
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/18396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ia7ebddc5499d59e37282e4f1e6513bc5f83cdb8a
Gerrit-Change-Number: 18396
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] [tests] make one scenario of client-test more stable

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18396 )

Change subject: [tests] make one scenario of client-test more stable
......................................................................

[tests] make one scenario of client-test more stable

This patch makes ClientTest.TestScannerKeepAlive more stable.

The motivation for this patch was seeing the following test
failure in a TSAN build [1]:

  src/kudu/client/client-test.cc:2763
  Failed
  Bad status: Not found: Scanner 0d9072070e4443ba8c49b089806415b4 not found (it may have expired)

Before: 2 out of 32 failed
  http://dist-test.cloudera.org/job?job_id=aserbin.1649379879.23423

After:  0 out of 32 failed
  http://dist-test.cloudera.org/job?job_id=aserbin.1649381490.37476

[1] http://jenkins.kudu.apache.org/job/kudu-gerrit/25299/BUILD_TYPE=TSAN

Change-Id: Ia7ebddc5499d59e37282e4f1e6513bc5f83cdb8a
Reviewed-on: http://gerrit.cloudera.org:8080/18396
Reviewed-by: Yingchun Lai <ac...@gmail.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/client/client-test.cc
1 file changed, 10 insertions(+), 6 deletions(-)

Approvals:
  Yingchun Lai: Looks good to me, approved
  Alexey Serbin: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7ebddc5499d59e37282e4f1e6513bc5f83cdb8a
Gerrit-Change-Number: 18396
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] [tests] make one scenario of client-test more stable

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18396 )

Change subject: [tests] make one scenario of client-test more stable
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7ebddc5499d59e37282e4f1e6513bc5f83cdb8a
Gerrit-Change-Number: 18396
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Fri, 08 Apr 2022 07:44:16 +0000
Gerrit-HasComments: No

[kudu-CR] [tests] make one scenario of client-test more stable

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18396 )

Change subject: [tests] make one scenario of client-test more stable
......................................................................


Patch Set 1: Verified+1

unrelated test failure in ClientTest.ClearCacheAndConcurrentWorkload


-- 
To view, visit http://gerrit.cloudera.org:8080/18396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7ebddc5499d59e37282e4f1e6513bc5f83cdb8a
Gerrit-Change-Number: 18396
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Fri, 08 Apr 2022 15:07:22 +0000
Gerrit-HasComments: No