You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/11/17 19:50:59 UTC
[kudu-CR](gh-pages) Fix list rendering of the last weekly update post
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5131
Change subject: Fix list rendering of the last weekly update post
......................................................................
Fix list rendering of the last weekly update post
The sublist after "Noteworthy features/improvements" is not rendering
properly. Apparently it was missing a new line to be indentified as a
list but adding it made things look weird too (a new line before the
list but none after). This makes the list a "definition list" which
boldens the title and avoids the new line weirdness at the cost of
extra indenting.
Change-Id: I78abc84ee430c0c73536ebc5691c39c47f836498
---
M _posts/2016-11-15-weekly-update.md
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/5131/1
--
To view, visit http://gerrit.cloudera.org:8080/5131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I78abc84ee430c0c73536ebc5691c39c47f836498
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
[kudu-CR](gh-pages) Fix list rendering of the last weekly update post
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Fix list rendering of the last weekly update post
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78abc84ee430c0c73536ebc5691c39c47f836498
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR](gh-pages) Fix list rendering of the last weekly update post
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.
Change subject: Fix list rendering of the last weekly update post
......................................................................
Fix list rendering of the last weekly update post
The sublist after "Noteworthy features/improvements" is not rendering
properly. Apparently it was missing a new line to be indentified as a
list but adding it made things look weird too (a new line before the
list but none after). This makes the list a "definition list" which
boldens the title and avoids the new line weirdness at the cost of
extra indenting.
Change-Id: I78abc84ee430c0c73536ebc5691c39c47f836498
Reviewed-on: http://gerrit.cloudera.org:8080/5131
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: David Ribeiro Alves <dr...@apache.org>
---
M _posts/2016-11-15-weekly-update.md
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
David Ribeiro Alves: Verified
Todd Lipcon: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/5131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I78abc84ee430c0c73536ebc5691c39c47f836498
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](gh-pages) Fix list rendering of the last weekly update post
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: Fix list rendering of the last weekly update post
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78abc84ee430c0c73536ebc5691c39c47f836498
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR](gh-pages) Fix list rendering of the last weekly update post
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has uploaded a new patch set (#2).
Change subject: Fix list rendering of the last weekly update post
......................................................................
Fix list rendering of the last weekly update post
The sublist after "Noteworthy features/improvements" is not rendering
properly. Apparently it was missing a new line to be indentified as a
list but adding it made things look weird too (a new line before the
list but none after). This makes the list a "definition list" which
boldens the title and avoids the new line weirdness at the cost of
extra indenting.
Change-Id: I78abc84ee430c0c73536ebc5691c39c47f836498
---
M _posts/2016-11-15-weekly-update.md
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/5131/2
--
To view, visit http://gerrit.cloudera.org:8080/5131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78abc84ee430c0c73536ebc5691c39c47f836498
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>