[jira] [Commented] (THRIFT-3926) There should be an error emitted when http status code is not 200

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15829576#comment-15829576 ] 

ASF GitHub Bot commented on THRIFT-3926:
----------------------------------------

Github user RobberPhex commented on the issue:

    https://github.com/apache/thrift/pull/1086
  
    status code not equal 200 doesn't means it's a `TApplicationException`.
    
    * When status code is 301/3xx, should thrift client follow the redirect?
    * In some server implements, server return Exception with 4xx, Exception contains the message "Access Denied"
    
    Httpcode is expression of server status, it can be used for debugging, for logging, not just a part of rpc.
    
    If someone want client process this error, return Exception when http code is not right, and client can parse and raise this exception.


> There should be an error emitted when http status code is not 200 
> ------------------------------------------------------------------
>
>                 Key: THRIFT-3926
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3926
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Node.js - Library
>            Reporter: 李飛
>            Assignee: 李飛
>
> Sometimes the thrift servers is not ready to serve requests from the client. The status code of response from the services is 40x or 50x. But the client is never telled in this version of http_connections. There is no error at all even when the response protocol is bad.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)