You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@syncope.apache.org by "Francesco Chicchiriccò (JIRA)" <ji...@apache.org> on 2017/08/17 07:04:00 UTC

[jira] [Commented] (SYNCOPE-1198) Make the signature algorithm configurable for SAML SSO

    [ https://issues.apache.org/jira/browse/SYNCOPE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130027#comment-16130027 ] 

Francesco Chicchiriccò commented on SYNCOPE-1198:
-------------------------------------------------

The patch looks good.
Does it make sense to introduce an enum for supported algorithms (as we already do elsewhere) or not?

> Make the signature algorithm configurable for SAML SSO
> ------------------------------------------------------
>
>                 Key: SYNCOPE-1198
>                 URL: https://issues.apache.org/jira/browse/SYNCOPE-1198
>             Project: Syncope
>          Issue Type: Improvement
>            Reporter: Colm O hEigeartaigh
>            Assignee: Colm O hEigeartaigh
>             Fix For: 2.0.5, 2.1.0
>
>         Attachments: SYNCOPE-1198.patch
>
>
> This task is to make the signature algorithm configurable for SAML SSO. Currently it is hard-coded depending on the key in question. I propose to add a new configuration property "signature.algorithm" to the saml2sp-logic.properties file. If undefined then it defaults to the previous behaviour.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)