You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by gi...@git.apache.org on 2017/08/18 22:54:06 UTC

[GitHub] jaydoane commented on issue #762: Use fully qualified call to allow code upgrade

jaydoane commented on issue #762: Use fully qualified call to allow code upgrade
URL: https://github.com/apache/couchdb/pull/762#issuecomment-323478044
 
 
   Curiously, I'm not seeing the expected behavior described under **Testing recommendations**.
   
   I modified rexi_monitor.erl to export `wait_monitors/1`, and then ran the test:
   ```erlang
   (node1@127.0.0.1)17> Self = self(), spawn(fun() -> rexi_monitor:wait_monitors(Self) end).
   <0.6576.228>
   (node1@127.0.0.1)18> code:soft_purge(rexi_monitor).
   true
   ```
   Nevertheless, this PR LGTM
   +1
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services