You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mxnet.apache.org by fr...@gmail.com, fr...@gmail.com on 2018/11/19 22:04:01 UTC

Re: Updating MXNet's Cub

I created a PR to address this issue:
https://github.com/apache/incubator-mxnet/pull/13322

Simply change cub submodule's URL will impact every developer. The recommended command: "git submodule update" won't work. Developer has to run "git submodule sync" first.

To minimize the impact, I deleted CUB submodule and added a new submodule: "nvidia_cub". the only side effect is there will be a dangling untracked folder "cub" in local disk. Developer can delete it manually.

Thanks,
Frank


On 2018/08/24 17:00:54, Hagay Lupesko <lu...@gmail.com> wrote: 
> Hi all,
> 
> 
> One of MXNet’s submodule dependencies is a snapshot of Nvidia Cub (
> https://github.com/dmlc/cub) – the snapshot is of an older version of Cub
> (1.7), while the latest Nvidia Cub release is 1.8.  Note that dmlc/cub has
> no customizations of the source Cub repo.
> 
> 
> I’d like to suggest to update the existing Cub submodule to Nvidia’s Cub
> repo. Instead of the snapshot, MXNet will be using Nvidia’s repo and the
> latest release (both repos have the same BSD-3 license, so licensing should
> not be an issue).
> 
> 
> Wanted to get feedback from the community to make sure I'm not missing
> anything.
> 
> if there are no objections I'll submit a PR for the change.
> 
> 
> Cheers,
> 
> Hagay
>

Re: Updating MXNet's Cub

Posted by Hagay Lupesko <lu...@gmail.com>.

Thanks for getting this done Frank!

On Fri, Nov 23, 2018 at 11:28 PM frankfliu2000@gmail.com <
frankfliu2000@gmail.com> wrote:

> I created a PR to address this issue:
> https://github.com/apache/incubator-mxnet/pull/13322
>
> Simply change cub submodule's URL will impact every developer. The
> recommended command: "git submodule update" won't work. Developer has to
> run "git submodule sync" first.
>
> To minimize the impact, I deleted CUB submodule and added a new submodule:
> "nvidia_cub". the only side effect is there will be a dangling untracked
> folder "cub" in local disk. Developer can delete it manually.
>
> Thanks,
> Frank
>
>
> On 2018/08/24 17:00:54, Hagay Lupesko <lu...@gmail.com> wrote:
> > Hi all,
> >
> >
> > One of MXNet’s submodule dependencies is a snapshot of Nvidia Cub (
> > https://github.com/dmlc/cub) – the snapshot is of an older version of
> Cub
> > (1.7), while the latest Nvidia Cub release is 1.8.  Note that dmlc/cub
> has
> > no customizations of the source Cub repo.
> >
> >
> > I’d like to suggest to update the existing Cub submodule to Nvidia’s Cub
> > repo. Instead of the snapshot, MXNet will be using Nvidia’s repo and the
> > latest release (both repos have the same BSD-3 license, so licensing
> should
> > not be an issue).
> >
> >
> > Wanted to get feedback from the community to make sure I'm not missing
> > anything.
> >
> > if there are no objections I'll submit a PR for the change.
> >
> >
> > Cheers,
> >
> > Hagay
> >
>