You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/10/29 01:19:00 UTC

[jira] [Work logged] (GOBBLIN-1305) Processing Split correctly in ORC RecordReader

     [ https://issues.apache.org/jira/browse/GOBBLIN-1305?focusedWorklogId=505989&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-505989 ]

ASF GitHub Bot logged work on GOBBLIN-1305:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Oct/20 01:18
            Start Date: 29/Oct/20 01:18
    Worklog Time Spent: 10m 
      Work Description: autumnust opened a new pull request #3143:
URL: https://github.com/apache/incubator-gobblin/pull/3143


   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - https://issues.apache.org/jira/browse/GOBBLIN-1305
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if applicable):
   The key change is inside `OrcValueCombineFileRecordReader.java` : It used to use `rows()`to get `RecordReader` from fileReader while it shouldn't be the case. The option it consumed will be able to set the range of records to be processed properly. 
   
   Other changes are mostly coordinating with the unit tests.
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 505989)
    Remaining Estimate: 0h
            Time Spent: 10m

> Processing Split correctly in ORC RecordReader
> ----------------------------------------------
>
>                 Key: GOBBLIN-1305
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1305
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Lei Sun
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)