You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:44:30 UTC
[GitHub] [incubator-doris] ccoffline opened a new pull request #4836: [Bug] Fix ClassCastException (#4833)
ccoffline opened a new pull request #4836:
URL: https://github.com/apache/incubator-doris/pull/4836
## Proposed changes
fix to #4833
## Types of changes
- [x] Bugfix (non-breaking change which fixes an issue)
- [] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [] Documentation Update (if none of the other choices apply)
- [] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
- [x] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [] I have added tests that prove my fix is effective or that my feature works
- [] If this change need a document change, I have updated the document
- [x] Any dependent changes have been merged
## Further comments
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #4836: [Bug] Fix ClassCastException (#4833)
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #4836:
URL: https://github.com/apache/incubator-doris/pull/4836#issuecomment-723462134
I think if the predicate like `substr(`dt`, 7, 8) in ('09')`, we should not do the partition prunner.
So here:
https://github.com/apache/incubator-doris/blob/f40868a4805f0ba503bcca9a9c04f704b61c121b/fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java#L958-L972
We should check if `inPredicate.getChild(0)` is not a slotRef, do not create partition filter for it.
So it won't goes to the `compareLiteral()` logic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] ccoffline commented on pull request #4836: [Bug] Fix ClassCastException (#4833)
Posted by GitBox <gi...@apache.org>.
ccoffline commented on pull request #4836:
URL: https://github.com/apache/incubator-doris/pull/4836#issuecomment-723740942
@morningman I think cast `CastExpr` to `LiteralExpr` will definitely cause an exception.
I just don't know whether `getResultValue()` will solve that though I didn't see anything wrong in the test.
https://github.com/apache/incubator-doris/blob/b1c1ffda4a0d5ff2f0be4f9d2f25997a31537ea8/fe/fe-core/src/main/java/org/apache/doris/catalog/PartitionKey.java#L135-L150
I'm not fully understand the logic in `partition pruner`. Maybe it should be in another PR=.=
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] ccoffline closed pull request #4836: [Bug] Fix ClassCastException (#4833)
Posted by GitBox <gi...@apache.org>.
ccoffline closed pull request #4836:
URL: https://github.com/apache/incubator-doris/pull/4836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org