You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/07/26 15:07:50 UTC

[GitHub] [commons-lang] marcwrobel opened a new pull request, #926: Fix links in javadoc and documentations

marcwrobel opened a new pull request, #926:
URL: https://github.com/apache/commons-lang/pull/926

   - fix broken links (using their new URL, an alternative URL or a Wayback Machine link),
   - use direct links instead of redirects,
   - use HTTPS where possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on a diff in pull request #926: Fix links in Javadoc and documentations

Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #926:
URL: https://github.com/apache/commons-lang/pull/926#discussion_r935954134


##########
src/site/xdoc/building.xml:
##########
@@ -24,8 +24,8 @@ limitations under the License.
 <!-- ================================================== -->
 <section name="Overview">
 <p>
-  Commons Lang uses <a href="http://maven.apache.org">Maven</a> or
-  <a href="http://ant.apache.org">Ant</a> as a build system.
+  Commons Lang uses <a href="https://maven.apache.org">Maven</a> or
+  <a href="https://ant.apache.org">Ant</a> as a build system.

Review Comment:
   -1: We do not use Ant, only Maven.



##########
src/test/java/org/apache/commons/lang3/StringUtilsContainsTest.java:
##########
@@ -105,7 +105,7 @@ public void testContainsAny_StringCharArray() {
     }
 
     /**
-     * See http://www.oracle.com/technetwork/articles/javase/supplementary-142654.html
+     * See https://www.oracle.com/technetwork/articles/javase/supplementary-142654.html

Review Comment:
   There is no such URL, it redirects to https://www.oracle.com/technical-resources/articles/javase/supplementary.html
   



##########
src/main/java/org/apache/commons/lang3/builder/HashCodeBuilder.java:
##########
@@ -37,7 +37,7 @@
  *
  * <p>
  * This class enables a good {@code hashCode} method to be built for any class. It follows the rules laid out in
- * the book <a href="http://www.oracle.com/technetwork/java/effectivejava-136174.html">Effective Java</a> by Joshua Bloch. Writing a
+ * the book <a href="https://www.oracle.com/technetwork/java/effectivejava-136174.html">Effective Java</a> by Joshua Bloch. Writing a

Review Comment:
   There is no such page, it redirects to https://www.oracle.com/java/technologies/effectivejava.html



##########
src/main/java/org/apache/commons/lang3/CharEncoding.java:
##########
@@ -23,14 +23,14 @@
 /**
  * <p>Character encoding names required of every implementation of the Java platform.</p>
  *
- * <p>According to <a href="http://docs.oracle.com/javase/1.3/docs/api/java/lang/package-summary.html#charenc">JRE character
+ * <p>According to <a href="https://docs.oracle.com/javase/6/docs/api/java/nio/charset/Charset.html">JRE character

Review Comment:
   Javadoc references should be to Java **8** since this is the Java level this component requires.
   



##########
src/main/java/org/apache/commons/lang3/CharUtils.java:
##########
@@ -46,7 +46,7 @@ public class CharUtils {
     /**
      * Carriage return character CR ('\r', Unicode 000d).
      *
-     * @see <a href="http://docs.oracle.com/javase/specs/jls/se7/html/jls-3.html#jls-3.10.6">JLF: Escape Sequences
+     * @see <a href="https://docs.oracle.com/javase/specs/jls/se7/html/jls-3.html#jls-3.10.6">JLF: Escape Sequences

Review Comment:
   Should point to Java 8, not 7.



##########
src/main/java/org/apache/commons/lang3/SystemUtils.java:
##########
@@ -1084,7 +1084,7 @@ public class SystemUtils {
     // -----------------------------------------------------------------------
     // These MUST be declared after those above as they depend on the
     // values being set up
-    // OS names from http://www.vamphq.com/os.html
+    // OS names from http://lopica.sourceforge.net/os.html

Review Comment:
   Why? Let's not replace one (insecure) URL with another: "The connection to lopica.sourceforge.net is not secure" Also the comment is no longer true since we did not, in fact, get the data from lopica.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] marcwrobel commented on a diff in pull request #926: Fix links in Javadoc and documentations

Posted by GitBox <gi...@apache.org>.
marcwrobel commented on code in PR #926:
URL: https://github.com/apache/commons-lang/pull/926#discussion_r931000564


##########
src/main/java/org/apache/commons/lang3/CharEncoding.java:
##########
@@ -23,14 +23,14 @@
 /**
  * <p>Character encoding names required of every implementation of the Java platform.</p>
  *
- * <p>According to <a href="http://docs.oracle.com/javase/1.3/docs/api/java/lang/package-summary.html#charenc">JRE character
+ * <p>According to <a href="https://docs.oracle.com/javase/6/docs/api/java/lang/package-summary.html#charenc">JRE character

Review Comment:
   I found the original page on https://web.archive.org/web/20111127040714/http://docs.oracle.com/javase/1.3/docs/api/java/lang/package-summary.html.
   
   I found that https://docs.oracle.com/javase/6/docs/api/java/nio/charset/Charset.html now contains an equivalent documentation (paragraph _Standard charsets_). I will update the link accordingly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] codecov-commenter commented on pull request #926: Fix links in javadoc and documentations

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #926:
URL: https://github.com/apache/commons-lang/pull/926#issuecomment-1195614669

   # [Codecov](https://codecov.io/gh/apache/commons-lang/pull/926?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#926](https://codecov.io/gh/apache/commons-lang/pull/926?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db9fa78) into [master](https://codecov.io/gh/apache/commons-lang/commit/b0739b066af253fe6810fb050b915f8608a383e6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b0739b0) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff            @@
   ##             master     #926   +/-   ##
   =========================================
     Coverage     91.64%   91.64%           
     Complexity     7396     7396           
   =========================================
     Files           188      188           
     Lines         15772    15772           
     Branches       2972     2972           
   =========================================
     Hits          14455    14455           
     Misses          725      725           
     Partials        592      592           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/commons-lang/pull/926?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...in/java/org/apache/commons/lang3/CharEncoding.java](https://codecov.io/gh/apache/commons-lang/pull/926/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvQ2hhckVuY29kaW5nLmphdmE=) | `100.00% <ø> (ø)` | |
   | [.../main/java/org/apache/commons/lang3/CharUtils.java](https://codecov.io/gh/apache/commons-lang/pull/926/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvQ2hhclV0aWxzLmphdmE=) | `100.00% <ø> (ø)` | |
   | [...main/java/org/apache/commons/lang3/ClassUtils.java](https://codecov.io/gh/apache/commons-lang/pull/926/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvQ2xhc3NVdGlscy5qYXZh) | `90.83% <ø> (ø)` | |
   | [...va/org/apache/commons/lang3/StringEscapeUtils.java](https://codecov.io/gh/apache/commons-lang/pull/926/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvU3RyaW5nRXNjYXBlVXRpbHMuamF2YQ==) | `98.90% <ø> (ø)` | |
   | [...ain/java/org/apache/commons/lang3/StringUtils.java](https://codecov.io/gh/apache/commons-lang/pull/926/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvU3RyaW5nVXRpbHMuamF2YQ==) | `98.71% <ø> (ø)` | |
   | [...ain/java/org/apache/commons/lang3/SystemUtils.java](https://codecov.io/gh/apache/commons-lang/pull/926/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvU3lzdGVtVXRpbHMuamF2YQ==) | `94.00% <ø> (ø)` | |
   | [...c/main/java/org/apache/commons/lang3/Validate.java](https://codecov.io/gh/apache/commons-lang/pull/926/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvVmFsaWRhdGUuamF2YQ==) | `95.10% <ø> (ø)` | |
   | [...rg/apache/commons/lang3/builder/EqualsBuilder.java](https://codecov.io/gh/apache/commons-lang/pull/926/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvYnVpbGRlci9FcXVhbHNCdWlsZGVyLmphdmE=) | `78.30% <ø> (ø)` | |
   | [.../apache/commons/lang3/builder/HashCodeBuilder.java](https://codecov.io/gh/apache/commons-lang/pull/926/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvYnVpbGRlci9IYXNoQ29kZUJ1aWxkZXIuamF2YQ==) | `95.20% <ø> (ø)` | |
   | [...rg/apache/commons/lang3/builder/ToStringStyle.java](https://codecov.io/gh/apache/commons-lang/pull/926/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvYnVpbGRlci9Ub1N0cmluZ1N0eWxlLmphdmE=) | `89.74% <ø> (ø)` | |
   | ... and [8 more](https://codecov.io/gh/apache/commons-lang/pull/926/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on a diff in pull request #926: Fix links in javadoc and documentations

Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #926:
URL: https://github.com/apache/commons-lang/pull/926#discussion_r930542883


##########
src/site/xdoc/article2_4.xml:
##########
@@ -28,11 +28,11 @@ limitations under the License.
 issue to see what went on in the year of development between Lang 2.3 and 2.4.</p>
 <section name="Deprecations">
 <p>First, let us start with a couple of deprecations. As you can see in the release notes, we chose
-to deprecate the <a href="https://commons.apache.org/lang/api-release/org/apache/commons/lang/ObjectUtils.html#appendIdentityToString(java.lang.StringBuffer,%20java.lang.Object)"><code>ObjectUtils.appendIdentityToString(StringBuffer, Object)</code></a> method as its
+to deprecate the <a href="https://commons.apache.org/proper/commons-lang/javadocs/api-2.6/org/apache/commons/lang/ObjectUtils.html#appendIdentityToString(java.lang.StringBuffer,%20java.lang.Object)"><code>ObjectUtils.appendIdentityToString(StringBuffer, Object)</code></a> method as its

Review Comment:
   I do not think it makes sense for docs for version 2.4 to point to 2.6 pages.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on a diff in pull request #926: Fix links in Javadoc and documentations

Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #926:
URL: https://github.com/apache/commons-lang/pull/926#discussion_r936148171


##########
src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java:
##########
@@ -34,7 +34,7 @@
  *
  * <p> This class provides methods to build a good equals method for any
  * class. It follows rules laid out in
- * <a href="http://www.oracle.com/technetwork/java/effectivejava-136174.html">Effective Java</a>
+ * <a href="https://www.oracle.com/technetwork/java/effectivejava-136174.html">Effective Java</a>

Review Comment:
   Redirects to https://www.oracle.com/java/technologies/effectivejava.html



##########
src/main/java/org/apache/commons/lang3/builder/HashCodeBuilder.java:
##########
@@ -37,7 +37,7 @@
  *
  * <p>
  * This class enables a good {@code hashCode} method to be built for any class. It follows the rules laid out in
- * the book <a href="http://www.oracle.com/technetwork/java/effectivejava-136174.html">Effective Java</a> by Joshua Bloch. Writing a
+ * the book <a href="https://www.oracle.com/technetwork/java/effectivejava-136174.html">Effective Java</a> by Joshua Bloch. Writing a

Review Comment:
   Did you change the URL? I still see the old one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] marcwrobel commented on a diff in pull request #926: Fix links in Javadoc and documentations

Posted by GitBox <gi...@apache.org>.
marcwrobel commented on code in PR #926:
URL: https://github.com/apache/commons-lang/pull/926#discussion_r940288927


##########
src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java:
##########
@@ -34,7 +34,7 @@
  *
  * <p> This class provides methods to build a good equals method for any
  * class. It follows rules laid out in
- * <a href="http://www.oracle.com/technetwork/java/effectivejava-136174.html">Effective Java</a>
+ * <a href="https://www.oracle.com/technetwork/java/effectivejava-136174.html">Effective Java</a>

Review Comment:
   @garydgregory, I cannot update the PR for the time being. Feel free to apply the necessary changes. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on a diff in pull request #926: Fix links in Javadoc and documentations

Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #926:
URL: https://github.com/apache/commons-lang/pull/926#discussion_r930983212


##########
src/main/java/org/apache/commons/lang3/CharEncoding.java:
##########
@@ -23,14 +23,14 @@
 /**
  * <p>Character encoding names required of every implementation of the Java platform.</p>
  *
- * <p>According to <a href="http://docs.oracle.com/javase/1.3/docs/api/java/lang/package-summary.html#charenc">JRE character
+ * <p>According to <a href="https://docs.oracle.com/javase/6/docs/api/java/lang/package-summary.html#charenc">JRE character

Review Comment:
   There are no character encoding name at that URL; did you mean to point to https://docs.oracle.com/javase/8/docs/technotes/guides/intl/encoding.doc.html ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] marcwrobel commented on a diff in pull request #926: Fix links in Javadoc and documentations

Posted by GitBox <gi...@apache.org>.
marcwrobel commented on code in PR #926:
URL: https://github.com/apache/commons-lang/pull/926#discussion_r935999603


##########
src/main/java/org/apache/commons/lang3/CharEncoding.java:
##########
@@ -23,14 +23,14 @@
 /**
  * <p>Character encoding names required of every implementation of the Java platform.</p>
  *
- * <p>According to <a href="http://docs.oracle.com/javase/1.3/docs/api/java/lang/package-summary.html#charenc">JRE character
+ * <p>According to <a href="https://docs.oracle.com/javase/6/docs/api/java/nio/charset/Charset.html">JRE character

Review Comment:
   Fixes



##########
src/main/java/org/apache/commons/lang3/CharEncoding.java:
##########
@@ -23,14 +23,14 @@
 /**
  * <p>Character encoding names required of every implementation of the Java platform.</p>
  *
- * <p>According to <a href="http://docs.oracle.com/javase/1.3/docs/api/java/lang/package-summary.html#charenc">JRE character
+ * <p>According to <a href="https://docs.oracle.com/javase/6/docs/api/java/nio/charset/Charset.html">JRE character

Review Comment:
   Fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] marcwrobel commented on a diff in pull request #926: Fix links in Javadoc and documentations

Posted by GitBox <gi...@apache.org>.
marcwrobel commented on code in PR #926:
URL: https://github.com/apache/commons-lang/pull/926#discussion_r936004689


##########
src/site/xdoc/building.xml:
##########
@@ -24,8 +24,8 @@ limitations under the License.
 <!-- ================================================== -->
 <section name="Overview">
 <p>
-  Commons Lang uses <a href="http://maven.apache.org">Maven</a> or
-  <a href="http://ant.apache.org">Ant</a> as a build system.
+  Commons Lang uses <a href="https://maven.apache.org">Maven</a> or
+  <a href="https://ant.apache.org">Ant</a> as a build system.

Review Comment:
   This PR is primarily about fixing the links. But I removed the reference to Ant.



##########
src/test/java/org/apache/commons/lang3/StringUtilsContainsTest.java:
##########
@@ -105,7 +105,7 @@ public void testContainsAny_StringCharArray() {
     }
 
     /**
-     * See http://www.oracle.com/technetwork/articles/javase/supplementary-142654.html
+     * See https://www.oracle.com/technetwork/articles/javase/supplementary-142654.html

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] marcwrobel commented on a diff in pull request #926: Fix links in Javadoc and documentations

Posted by GitBox <gi...@apache.org>.
marcwrobel commented on code in PR #926:
URL: https://github.com/apache/commons-lang/pull/926#discussion_r936002904


##########
src/main/java/org/apache/commons/lang3/SystemUtils.java:
##########
@@ -1084,7 +1084,7 @@ public class SystemUtils {
     // -----------------------------------------------------------------------
     // These MUST be declared after those above as they depend on the
     // values being set up
-    // OS names from http://www.vamphq.com/os.html
+    // OS names from http://lopica.sourceforge.net/os.html

Review Comment:
   I checked on wayback machine and this page was moved to this url. The old domain now hosts the "Headquarter of Vampire Fetishists" ;).
   
   I removed the link since this is not true.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] marcwrobel commented on a diff in pull request #926: Fix links in Javadoc and documentations

Posted by GitBox <gi...@apache.org>.
marcwrobel commented on code in PR #926:
URL: https://github.com/apache/commons-lang/pull/926#discussion_r936003877


##########
src/main/java/org/apache/commons/lang3/builder/HashCodeBuilder.java:
##########
@@ -37,7 +37,7 @@
  *
  * <p>
  * This class enables a good {@code hashCode} method to be built for any class. It follows the rules laid out in
- * the book <a href="http://www.oracle.com/technetwork/java/effectivejava-136174.html">Effective Java</a> by Joshua Bloch. Writing a
+ * the book <a href="https://www.oracle.com/technetwork/java/effectivejava-136174.html">Effective Java</a> by Joshua Bloch. Writing a

Review Comment:
   URL replaced by https://www.oracle.com/java/technologies/effectivejava.html.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on a diff in pull request #926: Fix links in Javadoc and documentations

Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #926:
URL: https://github.com/apache/commons-lang/pull/926#discussion_r940160844


##########
src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java:
##########
@@ -34,7 +34,7 @@
  *
  * <p> This class provides methods to build a good equals method for any
  * class. It follows rules laid out in
- * <a href="http://www.oracle.com/technetwork/java/effectivejava-136174.html">Effective Java</a>
+ * <a href="https://www.oracle.com/technetwork/java/effectivejava-136174.html">Effective Java</a>

Review Comment:
   @marcwrobel ping?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] marcwrobel commented on a diff in pull request #926: Fix links in javadoc and documentations

Posted by GitBox <gi...@apache.org>.
marcwrobel commented on code in PR #926:
URL: https://github.com/apache/commons-lang/pull/926#discussion_r930817877


##########
src/site/xdoc/article2_4.xml:
##########
@@ -28,11 +28,11 @@ limitations under the License.
 issue to see what went on in the year of development between Lang 2.3 and 2.4.</p>
 <section name="Deprecations">
 <p>First, let us start with a couple of deprecations. As you can see in the release notes, we chose
-to deprecate the <a href="https://commons.apache.org/lang/api-release/org/apache/commons/lang/ObjectUtils.html#appendIdentityToString(java.lang.StringBuffer,%20java.lang.Object)"><code>ObjectUtils.appendIdentityToString(StringBuffer, Object)</code></a> method as its
+to deprecate the <a href="https://commons.apache.org/proper/commons-lang/javadocs/api-2.6/org/apache/commons/lang/ObjectUtils.html#appendIdentityToString(java.lang.StringBuffer,%20java.lang.Object)"><code>ObjectUtils.appendIdentityToString(StringBuffer, Object)</code></a> method as its

Review Comment:
   You are right, I have been lazy on that one. That's fixed for both 2.4 and 2.5 changelogs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] marcwrobel commented on a diff in pull request #926: Fix links in javadoc and documentations

Posted by GitBox <gi...@apache.org>.
marcwrobel commented on code in PR #926:
URL: https://github.com/apache/commons-lang/pull/926#discussion_r930817877


##########
src/site/xdoc/article2_4.xml:
##########
@@ -28,11 +28,11 @@ limitations under the License.
 issue to see what went on in the year of development between Lang 2.3 and 2.4.</p>
 <section name="Deprecations">
 <p>First, let us start with a couple of deprecations. As you can see in the release notes, we chose
-to deprecate the <a href="https://commons.apache.org/lang/api-release/org/apache/commons/lang/ObjectUtils.html#appendIdentityToString(java.lang.StringBuffer,%20java.lang.Object)"><code>ObjectUtils.appendIdentityToString(StringBuffer, Object)</code></a> method as its
+to deprecate the <a href="https://commons.apache.org/proper/commons-lang/javadocs/api-2.6/org/apache/commons/lang/ObjectUtils.html#appendIdentityToString(java.lang.StringBuffer,%20java.lang.Object)"><code>ObjectUtils.appendIdentityToString(StringBuffer, Object)</code></a> method as its

Review Comment:
   You are right, that's fixed for both 2.4 and 2.5 changelogs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory merged pull request #926: Fix links in Javadoc and documentations

Posted by GitBox <gi...@apache.org>.
garydgregory merged PR #926:
URL: https://github.com/apache/commons-lang/pull/926


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] marcwrobel commented on a diff in pull request #926: Fix links in Javadoc and documentations

Posted by GitBox <gi...@apache.org>.
marcwrobel commented on code in PR #926:
URL: https://github.com/apache/commons-lang/pull/926#discussion_r935999745


##########
src/main/java/org/apache/commons/lang3/CharUtils.java:
##########
@@ -46,7 +46,7 @@ public class CharUtils {
     /**
      * Carriage return character CR ('\r', Unicode 000d).
      *
-     * @see <a href="http://docs.oracle.com/javase/specs/jls/se7/html/jls-3.html#jls-3.10.6">JLF: Escape Sequences
+     * @see <a href="https://docs.oracle.com/javase/specs/jls/se7/html/jls-3.html#jls-3.10.6">JLF: Escape Sequences

Review Comment:
   Fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org