You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltaspike.apache.org by Romain Manni-Bucau <rm...@gmail.com> on 2016/07/07 22:42:55 UTC
@Priority interceptors
Hello guys,
thanks
to org.apache.deltaspike.core.impl.interceptor.GlobalInterceptorExtension
we promote our interceptors with a @Priority but if they are provided in
beans.xml too we got warnings on some servers.
Should we rework this logic or our packaging?
wdyt?
Side note: my workaround is:
deactivate.org.apache.deltaspike.core.impl.interceptor.GlobalInterceptorExtension
= true
org.apache.deltaspike.core.spi.activation.ClassDeactivator =
org.apache.deltaspike.core.impl.activation.DefaultClassDeactivator
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
<http://www.tomitribe.com> | JavaEE Factory
<https://javaeefactory-rmannibucau.rhcloud.com>
Re: @Priority interceptors
Posted by Gerhard Petracek <ge...@gmail.com>.
@all:
fyi: since it just impacts owb(/tomee7), we continue the discussion on the
dev-list of owb (for now).
regards,
gerhard
2016-07-08 12:15 GMT+02:00 Romain Manni-Bucau <rm...@gmail.com>:
> Well the hint is one thing, was more speaking about the warning
> "interceptor already registered".
>
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> <https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> <http://www.tomitribe.com> | JavaEE Factory
> <https://javaeefactory-rmannibucau.rhcloud.com>
>
> 2016-07-08 12:01 GMT+02:00 Gerhard Petracek <ge...@gmail.com>:
>
> > with some ee7 servers you also see other warnings like hints about
> > @WithAnnotations.
> > -> (with some servers) you won't get rid of all warnings
> > -> it might be better for ee-servers to provide a config to disable such
> > hints for libs which are known to work with ee7, but still support ee6.
> >
> > regards,
> > gerhard
> >
> >
> >
> > 2016-07-08 11:32 GMT+02:00 Romain Manni-Bucau <rm...@gmail.com>:
> >
> > > 2016-07-08 11:18 GMT+02:00 Gerhard Petracek <
> gerhard.petracek@gmail.com
> > >:
> > >
> > > > hi romain,
> > > >
> > > > we could add an (additional) config-option to disable it.
> > > >
> > > >
> > > Issue is more about the default since it pops up when dropping DS. The
> > > deactivation itself can be done with the previous config.
> > >
> > >
> > > > with deltaspike v2 we can
> > > > - drop the entries in our beans.xml files
> > > > - remove GlobalInterceptorExtension (+ annotate the classes
> directly)
> > > >
> > > >
> > > +1
> > >
> > >
> > > > regards,
> > > > gerhard
> > > >
> > > >
> > > >
> > > > 2016-07-08 0:42 GMT+02:00 Romain Manni-Bucau <rmannibucau@gmail.com
> >:
> > > >
> > > > > Hello guys,
> > > > >
> > > > > thanks
> > > > > to
> > > org.apache.deltaspike.core.impl.interceptor.GlobalInterceptorExtension
> > > > > we promote our interceptors with a @Priority but if they are
> provided
> > > in
> > > > > beans.xml too we got warnings on some servers.
> > > > >
> > > > > Should we rework this logic or our packaging?
> > > > >
> > > > > wdyt?
> > > > >
> > > > >
> > > > > Side note: my workaround is:
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
> deactivate.org.apache.deltaspike.core.impl.interceptor.GlobalInterceptorExtension
> > > > > = true
> > > > > org.apache.deltaspike.core.spi.activation.ClassDeactivator =
> > > > > org.apache.deltaspike.core.impl.activation.DefaultClassDeactivator
> > > > >
> > > > >
> > > > > Romain Manni-Bucau
> > > > > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > > > > <https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog
> > > > > <http://rmannibucau.wordpress.com> | Github <
> > > > > https://github.com/rmannibucau> |
> > > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > > > > <http://www.tomitribe.com> | JavaEE Factory
> > > > > <https://javaeefactory-rmannibucau.rhcloud.com>
> > > > >
> > > >
> > >
> >
>
Re: @Priority interceptors
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Well the hint is one thing, was more speaking about the warning
"interceptor already registered".
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
<http://www.tomitribe.com> | JavaEE Factory
<https://javaeefactory-rmannibucau.rhcloud.com>
2016-07-08 12:01 GMT+02:00 Gerhard Petracek <ge...@gmail.com>:
> with some ee7 servers you also see other warnings like hints about
> @WithAnnotations.
> -> (with some servers) you won't get rid of all warnings
> -> it might be better for ee-servers to provide a config to disable such
> hints for libs which are known to work with ee7, but still support ee6.
>
> regards,
> gerhard
>
>
>
> 2016-07-08 11:32 GMT+02:00 Romain Manni-Bucau <rm...@gmail.com>:
>
> > 2016-07-08 11:18 GMT+02:00 Gerhard Petracek <gerhard.petracek@gmail.com
> >:
> >
> > > hi romain,
> > >
> > > we could add an (additional) config-option to disable it.
> > >
> > >
> > Issue is more about the default since it pops up when dropping DS. The
> > deactivation itself can be done with the previous config.
> >
> >
> > > with deltaspike v2 we can
> > > - drop the entries in our beans.xml files
> > > - remove GlobalInterceptorExtension (+ annotate the classes directly)
> > >
> > >
> > +1
> >
> >
> > > regards,
> > > gerhard
> > >
> > >
> > >
> > > 2016-07-08 0:42 GMT+02:00 Romain Manni-Bucau <rm...@gmail.com>:
> > >
> > > > Hello guys,
> > > >
> > > > thanks
> > > > to
> > org.apache.deltaspike.core.impl.interceptor.GlobalInterceptorExtension
> > > > we promote our interceptors with a @Priority but if they are provided
> > in
> > > > beans.xml too we got warnings on some servers.
> > > >
> > > > Should we rework this logic or our packaging?
> > > >
> > > > wdyt?
> > > >
> > > >
> > > > Side note: my workaround is:
> > > >
> > > >
> > > >
> > >
> >
> deactivate.org.apache.deltaspike.core.impl.interceptor.GlobalInterceptorExtension
> > > > = true
> > > > org.apache.deltaspike.core.spi.activation.ClassDeactivator =
> > > > org.apache.deltaspike.core.impl.activation.DefaultClassDeactivator
> > > >
> > > >
> > > > Romain Manni-Bucau
> > > > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > > > <https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog
> > > > <http://rmannibucau.wordpress.com> | Github <
> > > > https://github.com/rmannibucau> |
> > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > > > <http://www.tomitribe.com> | JavaEE Factory
> > > > <https://javaeefactory-rmannibucau.rhcloud.com>
> > > >
> > >
> >
>
Re: @Priority interceptors
Posted by Gerhard Petracek <ge...@gmail.com>.
with some ee7 servers you also see other warnings like hints about
@WithAnnotations.
-> (with some servers) you won't get rid of all warnings
-> it might be better for ee-servers to provide a config to disable such
hints for libs which are known to work with ee7, but still support ee6.
regards,
gerhard
2016-07-08 11:32 GMT+02:00 Romain Manni-Bucau <rm...@gmail.com>:
> 2016-07-08 11:18 GMT+02:00 Gerhard Petracek <ge...@gmail.com>:
>
> > hi romain,
> >
> > we could add an (additional) config-option to disable it.
> >
> >
> Issue is more about the default since it pops up when dropping DS. The
> deactivation itself can be done with the previous config.
>
>
> > with deltaspike v2 we can
> > - drop the entries in our beans.xml files
> > - remove GlobalInterceptorExtension (+ annotate the classes directly)
> >
> >
> +1
>
>
> > regards,
> > gerhard
> >
> >
> >
> > 2016-07-08 0:42 GMT+02:00 Romain Manni-Bucau <rm...@gmail.com>:
> >
> > > Hello guys,
> > >
> > > thanks
> > > to
> org.apache.deltaspike.core.impl.interceptor.GlobalInterceptorExtension
> > > we promote our interceptors with a @Priority but if they are provided
> in
> > > beans.xml too we got warnings on some servers.
> > >
> > > Should we rework this logic or our packaging?
> > >
> > > wdyt?
> > >
> > >
> > > Side note: my workaround is:
> > >
> > >
> > >
> >
> deactivate.org.apache.deltaspike.core.impl.interceptor.GlobalInterceptorExtension
> > > = true
> > > org.apache.deltaspike.core.spi.activation.ClassDeactivator =
> > > org.apache.deltaspike.core.impl.activation.DefaultClassDeactivator
> > >
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > > <https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog
> > > <http://rmannibucau.wordpress.com> | Github <
> > > https://github.com/rmannibucau> |
> > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > > <http://www.tomitribe.com> | JavaEE Factory
> > > <https://javaeefactory-rmannibucau.rhcloud.com>
> > >
> >
>
Re: @Priority interceptors
Posted by Romain Manni-Bucau <rm...@gmail.com>.
2016-07-08 11:18 GMT+02:00 Gerhard Petracek <ge...@gmail.com>:
> hi romain,
>
> we could add an (additional) config-option to disable it.
>
>
Issue is more about the default since it pops up when dropping DS. The
deactivation itself can be done with the previous config.
> with deltaspike v2 we can
> - drop the entries in our beans.xml files
> - remove GlobalInterceptorExtension (+ annotate the classes directly)
>
>
+1
> regards,
> gerhard
>
>
>
> 2016-07-08 0:42 GMT+02:00 Romain Manni-Bucau <rm...@gmail.com>:
>
> > Hello guys,
> >
> > thanks
> > to org.apache.deltaspike.core.impl.interceptor.GlobalInterceptorExtension
> > we promote our interceptors with a @Priority but if they are provided in
> > beans.xml too we got warnings on some servers.
> >
> > Should we rework this logic or our packaging?
> >
> > wdyt?
> >
> >
> > Side note: my workaround is:
> >
> >
> >
> deactivate.org.apache.deltaspike.core.impl.interceptor.GlobalInterceptorExtension
> > = true
> > org.apache.deltaspike.core.spi.activation.ClassDeactivator =
> > org.apache.deltaspike.core.impl.activation.DefaultClassDeactivator
> >
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > <https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog
> > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > <http://www.tomitribe.com> | JavaEE Factory
> > <https://javaeefactory-rmannibucau.rhcloud.com>
> >
>
Re: @Priority interceptors
Posted by Gerhard Petracek <ge...@gmail.com>.
hi romain,
we could add an (additional) config-option to disable it.
with deltaspike v2 we can
- drop the entries in our beans.xml files
- remove GlobalInterceptorExtension (+ annotate the classes directly)
regards,
gerhard
2016-07-08 0:42 GMT+02:00 Romain Manni-Bucau <rm...@gmail.com>:
> Hello guys,
>
> thanks
> to org.apache.deltaspike.core.impl.interceptor.GlobalInterceptorExtension
> we promote our interceptors with a @Priority but if they are provided in
> beans.xml too we got warnings on some servers.
>
> Should we rework this logic or our packaging?
>
> wdyt?
>
>
> Side note: my workaround is:
>
>
> deactivate.org.apache.deltaspike.core.impl.interceptor.GlobalInterceptorExtension
> = true
> org.apache.deltaspike.core.spi.activation.ClassDeactivator =
> org.apache.deltaspike.core.impl.activation.DefaultClassDeactivator
>
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> <https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> <http://www.tomitribe.com> | JavaEE Factory
> <https://javaeefactory-rmannibucau.rhcloud.com>
>