You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/02/03 08:36:42 UTC

[GitHub] [zookeeper] yfxhust opened a new pull request #1242: ZOOKEEPER-3712: Add setKeepAlive support for NIOServerCnxn.

yfxhust opened a new pull request #1242: ZOOKEEPER-3712: Add setKeepAlive support for NIOServerCnxn.
URL: https://github.com/apache/zookeeper/pull/1242
 
 
   Author: Fangxi Yin <yi...@kuaishou.com>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] asfgit closed pull request #1242: ZOOKEEPER-3712: Add setKeepAlive support for NIOServerCnxn.

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1242: ZOOKEEPER-3712: Add setKeepAlive support for NIOServerCnxn.
URL: https://github.com/apache/zookeeper/pull/1242
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] yfxhust commented on issue #1242: ZOOKEEPER-3712: Add setKeepAlive support for NIOServerCnxn.

Posted by GitBox <gi...@apache.org>.
yfxhust commented on issue #1242: ZOOKEEPER-3712: Add setKeepAlive support for NIOServerCnxn.
URL: https://github.com/apache/zookeeper/pull/1242#issuecomment-583283287
 
 
   > LGTM, once the documentation is added (for docs, the existing server socket keep alive setting `zookeeper.tcpKeepAlive` can be used as reference).
   
   Thanks for your comments. Added the doc with your suggestion. Please review the latest patch. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] yfxhust commented on a change in pull request #1242: ZOOKEEPER-3712: Add setKeepAlive support for NIOServerCnxn.

Posted by GitBox <gi...@apache.org>.
yfxhust commented on a change in pull request #1242: ZOOKEEPER-3712: Add setKeepAlive support for NIOServerCnxn.
URL: https://github.com/apache/zookeeper/pull/1242#discussion_r376262364
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java
 ##########
 @@ -81,6 +81,11 @@
      */
     private long sessionId;
 
+    /**
+     * Client socket option for TCP keepalive
+     */
+    private final boolean clientTcpKeepAlive = Boolean.getBoolean("zookeeper.clientTcpKeepAlive");
+
 
 Review comment:
   Thanks your comments. Accept it. I add items in zookeeperAdmin in latest patch. Please review it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] maoling commented on a change in pull request #1242: ZOOKEEPER-3712: Add setKeepAlive support for NIOServerCnxn.

Posted by GitBox <gi...@apache.org>.
maoling commented on a change in pull request #1242: ZOOKEEPER-3712: Add setKeepAlive support for NIOServerCnxn.
URL: https://github.com/apache/zookeeper/pull/1242#discussion_r374543092
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java
 ##########
 @@ -81,6 +81,11 @@
      */
     private long sessionId;
 
+    /**
+     * Client socket option for TCP keepalive
+     */
+    private final boolean clientTcpKeepAlive = Boolean.getBoolean("zookeeper.clientTcpKeepAlive");
+
 
 Review comment:
   please doc this new property in the `zookeeperAdmin.md`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services