[GitHub] [druid] suneet-s commented on a change in pull request #9432: Web console: expose props for S3

[GitBox <gi...@apache.org>]

suneet-s commented on a change in pull request #9432: Web console: expose props for S3
URL: https://github.com/apache/druid/pull/9432#discussion_r385961276
 
 

 ##########
 File path: web-console/src/utils/ingestion-spec.tsx
 ##########
 @@ -1206,6 +1206,30 @@ export function getIoConfigFormFields(ingestionComboType: IngestionComboType): F
             </>
           ),
         },
+        {
+          name: 'inputSource.properties.accessKeyId',
+          label: 'Access key ID',
+          type: 'string',
+          placeholder: '(optional)',
+          info: (
+            <>
+              <p>S3 access key for this S3 bucket.</p>
+              <p>Setting this will override the default configuration provided in the config.</p>
 
 Review comment:
   provided in which config? 
   
   Also default configuration -> access key used for deep storage?
   
   Same comment on line 1229

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org