You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by necosta <gi...@git.apache.org> on 2017/06/30 09:32:58 UTC
[GitHub] zeppelin pull request #2456: [ZEPPELIN-2714] Soft-code Spark UI button visua...
GitHub user necosta opened a pull request:
https://github.com/apache/zeppelin/pull/2456
[ZEPPELIN-2714] Soft-code Spark UI button visualization
### What is this PR for?
When "spark.ui.enabled" property is set to "false" we should not show the Spark UI button.
We keep the same behaviour when this property does not exist or when it exists and it's set to true.
### What type of PR is it?
[ Improvement]
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2714
### How should this be tested?
1. Open Zeppelin, go to Interpreter > Spark
1. Click spark ui > msg: "No spark application running"
1. Go to a paragraph, run "sc.parallelize(1 to 100).count()", check "SPARK JOB" button
1. Go to Interpreter > Spark > Set "spark.ui.enabled" to "false"
1. Rerun paragraph > "SPARK JOB" button not visible
1. Go to Interpreter > Spark > "spark ui" button not visible
Also, test with "spark.ui.enabled"="true" and other workflow combinations
### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? N
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin zeppelin2714
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2456.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2456
----
commit 4d7658f423d9e90dd50137edd2f2010952619985
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-06-30T09:17:59Z
[ZEPPELIN-2714] Soft-code Spark UI button visualization
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2456: [ZEPPELIN-2714] Soft-code Spark UI button visualizatio...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2456
Merge to master if no further comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2456: [ZEPPELIN-2714] Soft-code Spark UI button visualizatio...
Posted by necosta <gi...@git.apache.org>.
Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2456
@felixcheung , @Leemoonsoo , ready for re-review. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2456: [ZEPPELIN-2714] Soft-code Spark UI button visualizatio...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2456
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2456: [ZEPPELIN-2714] Soft-code Spark UI button visua...
Posted by necosta <gi...@git.apache.org>.
GitHub user necosta reopened a pull request:
https://github.com/apache/zeppelin/pull/2456
[ZEPPELIN-2714] Soft-code Spark UI button visualization
### What is this PR for?
When "spark.ui.enabled" property is set to "false" we should not show the Spark UI button.
We keep the same behaviour when this property does not exist or when it exists and it's set to true.
### What type of PR is it?
[ Improvement]
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2714
### How should this be tested?
1. Open Zeppelin, go to Interpreter > Spark
1. Click spark ui > msg: "No spark application running"
1. Go to a paragraph, run "sc.parallelize(1 to 100).count()", check "SPARK JOB" button
1. Go to Interpreter > Spark > Set "spark.ui.enabled" to "false"
1. Rerun paragraph > "SPARK JOB" button not visible
1. Go to Interpreter > Spark > "spark ui" button not visible
Also, test with "spark.ui.enabled"="true" and other workflow combinations
### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? N
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin zeppelin2714
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2456.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2456
----
commit 4d7658f423d9e90dd50137edd2f2010952619985
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-06-30T09:17:59Z
[ZEPPELIN-2714] Soft-code Spark UI button visualization
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2456: [ZEPPELIN-2714] Soft-code Spark UI button visua...
Posted by necosta <gi...@git.apache.org>.
Github user necosta closed the pull request at:
https://github.com/apache/zeppelin/pull/2456
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2456: [ZEPPELIN-2714] Soft-code Spark UI button visualizatio...
Posted by necosta <gi...@git.apache.org>.
Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2456
@Leemoonsoo , @felixcheung , one minor commit added. Fixed merge conflicts. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2456: [ZEPPELIN-2714] Soft-code Spark UI button visualizatio...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2456
LGTM.
merging if no more comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2456: [ZEPPELIN-2714] Soft-code Spark UI button visua...
Posted by necosta <gi...@git.apache.org>.
Github user necosta closed the pull request at:
https://github.com/apache/zeppelin/pull/2456
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2456: [ZEPPELIN-2714] Soft-code Spark UI button visua...
Posted by necosta <gi...@git.apache.org>.
GitHub user necosta reopened a pull request:
https://github.com/apache/zeppelin/pull/2456
[ZEPPELIN-2714] Soft-code Spark UI button visualization
### What is this PR for?
When "spark.ui.enabled" property is set to "false" we should not show the Spark UI button.
We keep the same behaviour when this property does not exist or when it exists and it's set to true.
### What type of PR is it?
[ Improvement]
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2714
### How should this be tested?
1. Open Zeppelin, go to Interpreter > Spark
1. Click spark ui > msg: "No spark application running"
1. Go to a paragraph, run "sc.parallelize(1 to 100).count()", check "SPARK JOB" button
1. Go to Interpreter > Spark > Set "spark.ui.enabled" to "false"
1. Rerun paragraph > "SPARK JOB" button not visible
1. Go to Interpreter > Spark > "spark ui" button not visible
Also, test with "spark.ui.enabled"="true" and other workflow combinations
### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? N
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin zeppelin2714
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2456.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2456
----
commit a85864c0168f4fb1ffefde7db2d118cd675c400b
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-06-30T09:17:59Z
[ZEPPELIN-2714] Soft-code Spark UI button visualization
commit 294dea8fbc3452c0caae072d45c60bcc02def069
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-07-03T20:38:01Z
[ZEPPELIN-2714] Improvements to change request
commit edf29cc1ed233497ea89d49dfe53cc863255c0b2
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-07-06T10:04:21Z
[ZEPPELIN-2714] Minor final fix
commit 278a23ee31cd7cc90a587124ca15c53e62af8e45
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-07-06T14:04:04Z
[ZEPPELIN-2714] Fixed broken unit-test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2456: [ZEPPELIN-2714] Soft-code Spark UI button visua...
Posted by necosta <gi...@git.apache.org>.
GitHub user necosta reopened a pull request:
https://github.com/apache/zeppelin/pull/2456
[ZEPPELIN-2714] Soft-code Spark UI button visualization
### What is this PR for?
When "spark.ui.enabled" property is set to "false" we should not show the Spark UI button.
We keep the same behaviour when this property does not exist or when it exists and it's set to true.
### What type of PR is it?
[ Improvement]
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2714
### How should this be tested?
1. Open Zeppelin, go to Interpreter > Spark
1. Click spark ui > msg: "No spark application running"
1. Go to a paragraph, run "sc.parallelize(1 to 100).count()", check "SPARK JOB" button
1. Go to Interpreter > Spark > Set "spark.ui.enabled" to "false"
1. Rerun paragraph > "SPARK JOB" button not visible
1. Go to Interpreter > Spark > "spark ui" button not visible
Also, test with "spark.ui.enabled"="true" and other workflow combinations
### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? N
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin zeppelin2714
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2456.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2456
----
commit 4d7658f423d9e90dd50137edd2f2010952619985
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-06-30T09:17:59Z
[ZEPPELIN-2714] Soft-code Spark UI button visualization
commit b0767c2173ae4e3529846388f9617aab291729f1
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-07-03T20:38:01Z
[ZEPPELIN-2714] Improvements to change request
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2456: [ZEPPELIN-2714] Soft-code Spark UI button visua...
Posted by necosta <gi...@git.apache.org>.
Github user necosta closed the pull request at:
https://github.com/apache/zeppelin/pull/2456
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2456: [ZEPPELIN-2714] Soft-code Spark UI button visua...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2456
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---