You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/02/03 17:17:57 UTC
[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #522:
HDDS-2975. Print Freon summary to log in non-interactive mode
adoroszlai opened a new pull request #522: HDDS-2975. Print Freon summary to log in non-interactive mode
URL: https://github.com/apache/hadoop-ozone/pull/522
## What changes were proposed in this pull request?
Freon prints progress to log in non-interactive mode since HDDS-2861, but summary statistics are still printed to standard output. This change proposes to print summary statistics to the log instead of the console in the non-interactive mode.
https://issues.apache.org/jira/browse/HDDS-2975
## How was this patch tested?
Tested Freon in both modes (using `-T` flag of `docker-compose exec`):
```
$ docker-compose exec --help
...
Options:
...
-T Disable pseudo-tty allocation. By default `docker-compose exec`
allocates a TTY.
...
$ docker-compose exec om ozone freon ockg -n 5 -t 1 -p interactive
...
2020-02-03 15:49:19,659 [main] INFO freon.BaseFreonGenerator: Executing test with prefix interactive
0.00% |? | 0/5 Time: 0:00:012020-02-03 15:49:21,341 [pool-1-thread-1] WARN impl.MetricsSystemImpl: ozone-freon metrics system already initialized!
100.00% |?????????????????????????????????????????????????????????????????????????????????????????????????????| 5/5 Time: 0:00:04
2/3/20, 3:49:23 PM =============================================================
-- Timers ----------------------------------------------------------------------
key-create
count = 5
mean rate = 1.64 calls/second
1-minute rate = 0.00 calls/second
5-minute rate = 0.00 calls/second
15-minute rate = 0.00 calls/second
min = 61.32 milliseconds
max = 1871.40 milliseconds
mean = 448.14 milliseconds
stddev = 712.96 milliseconds
median = 65.82 milliseconds
75% <= 176.41 milliseconds
95% <= 1871.40 milliseconds
98% <= 1871.40 milliseconds
99% <= 1871.40 milliseconds
99.9% <= 1871.40 milliseconds
Total execution time (sec): 4
Failures: 0
Successful executions: 5
$ docker-compose exec -T om ozone freon ockg -n 5 -t 1 -p noninteractive
...
2020-02-03 15:49:27,908 [main] INFO freon.BaseFreonGenerator: Executing test with prefix noninteractive
2020-02-03 15:49:27,915 [Thread-6] INFO freon.ProgressBar: Progress: 0.00 % (0 out of 5)
2020-02-03 15:49:28,920 [Thread-6] INFO freon.ProgressBar: Progress: 0.00 % (0 out of 5)
2020-02-03 15:49:29,571 [pool-1-thread-1] WARN impl.MetricsSystemImpl: ozone-freon metrics system already initialized!
2020-02-03 15:49:29,886 [Thread-6] INFO freon.ProgressBar: Progress: 0.00 % (0 out of 5)
2020-02-03 15:49:30,886 [Thread-6] INFO freon.ProgressBar: Progress: 100.00 % (5 out of 5)
2020-02-03 15:49:30,973 [Thread-5] INFO metrics: type=TIMER, name=key-create, count=5, min=54.2227, max=1714.7334, mean=388.4163, stddev=663.1605489068511, median=57.5416, p75=59.2239, p95=1714.7334, p98=1714.7334, p99=1714.7334, p999=1714.7334, mean_rate=2.4488359801005632, m1=0.0, m5=0.0, m15=0.0, rate_unit=events/second, duration_unit=milliseconds
2020-02-03 15:49:30,974 [Thread-5] INFO freon.BaseFreonGenerator: Total execution time (sec): 3
2020-02-03 15:49:30,975 [Thread-5] INFO freon.BaseFreonGenerator: Failures: 0
2020-02-03 15:49:30,975 [Thread-5] INFO freon.BaseFreonGenerator: Successful executions: 5
```
https://github.com/adoroszlai/hadoop-ozone/runs/423452418
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek closed pull request #522: HDDS-2975. Print
Freon summary to log in non-interactive mode
Posted by GitBox <gi...@apache.org>.
elek closed pull request #522: HDDS-2975. Print Freon summary to log in non-interactive mode
URL: https://github.com/apache/hadoop-ozone/pull/522
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on issue #522: HDDS-2975. Print
Freon summary to log in non-interactive mode
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #522: HDDS-2975. Print Freon summary to log in non-interactive mode
URL: https://github.com/apache/hadoop-ozone/pull/522#issuecomment-584170718
Thanks @elek for reviewing and committing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] anuengineer commented on issue #522: HDDS-2975.
Print Freon summary to log in non-interactive mode
Posted by GitBox <gi...@apache.org>.
anuengineer commented on issue #522: HDDS-2975. Print Freon summary to log in non-interactive mode
URL: https://github.com/apache/hadoop-ozone/pull/522#issuecomment-582048334
I am +1 on this change, and the failures in acceptance test does not seem to be related. That is, MR and S3 tests failing does not seem to be related to change in the Freon output. @adoroszlai Please feel free to commit after you take a look at the acceptance results. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on issue #522: HDDS-2975. Print
Freon summary to log in non-interactive mode
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #522: HDDS-2975. Print Freon summary to log in non-interactive mode
URL: https://github.com/apache/hadoop-ozone/pull/522#issuecomment-582054346
Thanks @anuengineer for the review.
Acceptance test seems to have gotten painfully slow. I would guess it's due to some environment issue, because it is failing even in simple doc translation PRs. Note that it is even hiding a genuine failure (see #527).
This change is not urgent, so I can wait until we can get a clean acceptance test run.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org