[GitHub] [incubator-uniffle] xianjingfeng commented on a diff in pull request #954: [#381]imporvement(server): Check JAVA_HOME and HADOOP_HOME in start-shuffle-server.sh

["xianjingfeng (via GitHub)" <gi...@apache.org>]

xianjingfeng commented on code in PR #954:
URL: https://github.com/apache/incubator-uniffle/pull/954#discussion_r1232484313


##########
build_distribution.sh:
##########
@@ -97,7 +97,7 @@ cd $RSS_HOME
 
 if [ -z "$JAVA_HOME" ]; then
   echo "Error: JAVA_HOME is not set, cannot proceed."
-  exit -1

Review Comment:
   Why do we need to change this line?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org