[jira] [Commented] (OAK-6615) Add new segment-tar fixture for attaching a cold-standby to benchmarked primary

["Michael Dürig (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-6615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207129#comment-16207129 ] 

Michael Dürig commented on OAK-6615:
------------------------------------

Patch LGTM, just a few details: 

* Could we move {{SegmentTarFixture.SegmentTarFixtureBuilder}} to {{OakFixture}} and expose it from there through a static method instead of the various (and confusing) overloads of {{OakFixture.getSegmentTar}}? 
* {{SegmentTarFixture#setUpCluster}} is confusingly long and nested. Would be great to simplify that method.


> Add new segment-tar fixture for attaching a cold-standby to benchmarked primary
> -------------------------------------------------------------------------------
>
>                 Key: OAK-6615
>                 URL: https://issues.apache.org/jira/browse/OAK-6615
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: benchmarks, segment-tar
>            Reporter: Andrei Dulceanu
>            Assignee: Andrei Dulceanu
>            Priority: Minor
>              Labels: cold-standby
>             Fix For: 1.8, 1.7.10
>
>         Attachments: OAK-6615.patch
>
>
> If this fixture is chosen, a cold standby instance will be started, syncing with the primary every {{n}} seconds. All the benchmarks specified via {{[testcases]}} argument will be run on primary instance, and all statistics and reports will be linked to primary.
> This could work similarly to {{Oak-Segment-Tar-DS}} and have dedicated options like {{--no-data-store}}, {{--private-data-store}} or {{--shared-data-store}}. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)