You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "xianjingfeng (via GitHub)" <gi...@apache.org> on 2023/03/25 06:33:33 UTC
[GitHub] [incubator-uniffle] xianjingfeng opened a new pull request, #760: [#716] improvement(operator): support specifying imagePullSecrets
xianjingfeng opened a new pull request, #760:
URL: https://github.com/apache/incubator-uniffle/pull/760
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
Support specifying imagePullSecrets
### Why are the changes needed?
If the images are stored in a private registry, Kubernetes needs to be provided with the necessary credentials to authenticate with the registry.
Fix: #716
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] xianjingfeng commented on pull request #760: [#716] improvement(operator): support specifying imagePullSecrets
Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng commented on PR #760:
URL: https://github.com/apache/incubator-uniffle/pull/760#issuecomment-1483982511
> By the way, would you mind to rebase your pr with the latest master?
I created a new pr: #765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] xianjingfeng closed pull request #760: [#716] improvement(operator): support specifying imagePullSecrets
Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng closed pull request #760: [#716] improvement(operator): support specifying imagePullSecrets
URL: https://github.com/apache/incubator-uniffle/pull/760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #760: [#716] improvement(operator): support specifying imagePullSecrets
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #760:
URL: https://github.com/apache/incubator-uniffle/pull/760#issuecomment-1483743132
## [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/760?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#760](https://codecov.io/gh/apache/incubator-uniffle/pull/760?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f07b984) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/567872b8c89a19c16e31c7919ab196fe7568c02a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (567872b) will **increase** coverage by `2.20%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #760 +/- ##
============================================
+ Coverage 60.67% 62.88% +2.20%
Complexity 1901 1901
============================================
Files 239 225 -14
Lines 13031 11067 -1964
Branches 1091 1091
============================================
- Hits 7907 6959 -948
+ Misses 4686 3728 -958
+ Partials 438 380 -58
```
[see 16 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-uniffle/pull/760/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] vinayakmalik95 commented on pull request #760: [#716] improvement(operator): support specifying imagePullSecrets
Posted by "vinayakmalik95 (via GitHub)" <gi...@apache.org>.
vinayakmalik95 commented on PR #760:
URL: https://github.com/apache/incubator-uniffle/pull/760#issuecomment-1486267681
thanks for quick look @xianjingfeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #760: [#716] improvement(operator): support specifying imagePullSecrets
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on code in PR #760:
URL: https://github.com/apache/incubator-uniffle/pull/760#discussion_r1148371449
##########
deploy/kubernetes/operator/api/uniffle/v1alpha1/remoteshuffleservice_types.go:
##########
@@ -59,6 +59,9 @@ type RemoteShuffleServiceSpec struct {
// ConfigMapName indicates configMap name stores configurations of coordinators and shuffle servers.
ConfigMapName string `json:"configMapName"`
+
+ // +optional
+ ImagePullSecrets []corev1.LocalObjectReference `json:"imagePullSecrets,omitempty" patchStrategy:"merge" patchMergeKey:"name" protobuf:"bytes,15,rep,name=imagePullSecrets"`
Review Comment:
I believe we don't need to add the patchStrategy, patchMergeKey etc into the struct tag.
##########
deploy/kubernetes/operator/api/uniffle/v1alpha1/remoteshuffleservice_types.go:
##########
@@ -59,6 +59,9 @@ type RemoteShuffleServiceSpec struct {
// ConfigMapName indicates configMap name stores configurations of coordinators and shuffle servers.
ConfigMapName string `json:"configMapName"`
+
+ // +optional
+ ImagePullSecrets []corev1.LocalObjectReference `json:"imagePullSecrets,omitempty" patchStrategy:"merge" patchMergeKey:"name" protobuf:"bytes,15,rep,name=imagePullSecrets"`
Review Comment:
I don't believe we need to add the patchStrategy, patchMergeKey etc into the struct tag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on pull request #760: [#716] improvement(operator): support specifying imagePullSecrets
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #760:
URL: https://github.com/apache/incubator-uniffle/pull/760#issuecomment-1483827327
By the way, would you mind to rebase your pr with the latest master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org