You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anindya Sinha <an...@apple.com> on 2017/04/11 23:09:45 UTC

Re: Review Request 57816: Add a scheduler flag `suppress_offers_on_registration`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57816/
-----------------------------------------------------------

(Updated April 11, 2017, 11:09 p.m.)


Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.


Changes
-------

Addressed review comments.


Summary (updated)
-----------------

Add a scheduler flag `suppress_offers_on_registration`.


Bugs: MESOS-7015
    https://issues.apache.org/jira/browse/MESOS-7015


Repository: mesos


Description
-------

If the framework sets this flag to indicate that it wants offers
suppressed on successful registration to master, we pass this
information to the master in the `SUBSCRIBE` call.


Diffs (updated)
-----

  src/sched/flags.hpp d19d20bad7dba48c8792783c73115affa1430cbe 
  src/sched/sched.cpp ef73c1dccfd736b79f40a057951f022df7f60644 


Diff: https://reviews.apache.org/r/57816/diff/3/

Changes: https://reviews.apache.org/r/57816/diff/2-3/


Testing
-------

All tests passed.


Thanks,

Anindya Sinha


Re: Review Request 57816: Add a scheduler flag `suppress_offers_on_registration`.

Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57816/
-----------------------------------------------------------

(Updated May 5, 2017, 2:21 a.m.)


Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.


Bugs: MESOS-7015
    https://issues.apache.org/jira/browse/MESOS-7015


Repository: mesos


Description
-------

If the framework sets this flag to indicate that it wants offers
suppressed on successful registration to master, we pass this
information to the master in the `SUBSCRIBE` call.


Diffs
-----

  src/sched/flags.hpp d19d20bad7dba48c8792783c73115affa1430cbe 
  src/sched/sched.cpp ef73c1dccfd736b79f40a057951f022df7f60644 


Diff: https://reviews.apache.org/r/57816/diff/4/


Testing
-------

All tests passed.


Thanks,

Anindya Sinha


Re: Review Request 57816: Add a scheduler flag `suppress_offers_on_registration`.

Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57816/
-----------------------------------------------------------

(Updated April 15, 2017, 6:40 a.m.)


Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.


Changes
-------

Updated based on change in `SUBSCRIBE` message definition.


Bugs: MESOS-7015
    https://issues.apache.org/jira/browse/MESOS-7015


Repository: mesos


Description
-------

If the framework sets this flag to indicate that it wants offers
suppressed on successful registration to master, we pass this
information to the master in the `SUBSCRIBE` call.


Diffs (updated)
-----

  src/sched/flags.hpp d19d20bad7dba48c8792783c73115affa1430cbe 
  src/sched/sched.cpp ef73c1dccfd736b79f40a057951f022df7f60644 


Diff: https://reviews.apache.org/r/57816/diff/4/

Changes: https://reviews.apache.org/r/57816/diff/3-4/


Testing
-------

All tests passed.


Thanks,

Anindya Sinha